queoahfh

7 ms·

1. 1.▲
   by queoahfh 2mo ago

   I wrongly guessed that the boolean in the original C code was for error handling when I skimmed it, but instead it is just a result value, while elog() and related macros/functions are used for general error handling in the C version.
2. 2.▲
   by queoahfh 2mo ago

   Yes, but the original boolean seems to have been used for error handling, and the tagged union is also used for error handling. Why have both simultaneously in the same function instead of just one of the two? Edit: Looking at the code agai
3. 3.▲
   by queoahfh 2mo ago

   I am concerned about the quality. Even a cursory skim of the code makes the code appear asinine. Unless the genius aspects of the code elude me. https://github.com/malisper/pgrust/blob/3646a73515a5e4ac7d0b...
4. 4.▲
   by queoahfh 2mo ago

   From what I skimmed manually, not that many, but the code itself seems labyrinthical. Like, why have both Rust Try-supporting Error-like tagged union, but also booleans, for error handling, in the same function? https://github.co
5. 5.▲
   by queoahfh 2mo ago

   What a peculiar kind of rewrite. Rust: https://github.com/malisper/pgrust/blob/3646a73515a5e4ac7d0b... Original: https://github.com/postgres/postgres/blob/df293aed46e3133df3...
6. 6.▲
   by queoahfh 2mo ago

   Didn't the initial rewrite of Bun into Rust have an ocean of "unsafe" in it, and wasn't it entirely dysfunctional?