Tyriar

5 ms·

1.
by Tyriar 8mo ago
We're planning on switching the default in 1.109 with https://github.com/microsoft/vscode/issues/287073 My main hesitation here was that really it's just a false sense of security though. Tasks is j
2.
by Tyriar 8mo ago
Syntax highlighting should work if the highlighting is provided by a textmate grammar, it will not work if it's semantic highlighting provided by an extension and that extension requires workspace trust. If it's possible to highli
3.
by Tyriar 8mo ago
Didn't mean to come off that way, I know a lot of the decisions that were made. One thing I've got from this is we should probably open `/tmp/`, `C:\`, ~/`, etc. in restricted mode without asking the user. But a lot
4.
by Tyriar 8mo ago
Good point about one off edits and logs, thanks for all the insights. I'll pass these discussions on to the feature owner!
5.
by Tyriar 8mo ago
AI certainly made everything in this area more complicated. I 100% agree about sandboxing and we have people investing in this right now, there's an early opt-in version we just landed recently in Insiders.
6.
by Tyriar 8mo ago
Some JIT notification to enable it and/or a status bar/banner was considered, but ultimately this was chosen to improve the user experience. Instead of opening a folder, having it restricted and editing code being broken until you
7.
by Tyriar 8mo ago
It's intentionally prominent as you're in a potentially very degraded experience. You can just click the x to hide it which is remembered the next time you open the folder. Not having this banner be really obvious would lead to fr
8.
by Tyriar 8mo ago
> I don't have a flash of insight over what my risk exposure might be for what I'm opening at this moment Maybe I'm too close to it, but the first sentence gives a very clear outline of the risk to me; Trusting this folder
9.
by Tyriar 8mo ago
"May" is the most correct word though, it's not guaranteed and VS Code (core) doesn't actually know if things will execute or not as a result of this due to extensions also depending on the feature. Running the "Man
10.
by Tyriar 8mo ago
It's not just the .vscode folder though, the Python extension for example executes code in order to provide language services. How could this threat detection possibly be complete? In this new LLM-assisted world a malicious repository
11.
by Tyriar 8mo ago
VS Code team member here :wave: As called out elsewhere, workspace trust is literally the protection here which is being circumvented. You're warned when you open a folder whether you trust the origin/authors with pretty strong wo
12.
by Tyriar 8mo ago
Various settings are `restricted` in the codebase to only use them when the workspace is trusted. `allowAutomaticTasks` is one such setting: https://github.com/microsoft/vscode/blob/f7730c409e14af94d75... So
13.
by Tyriar 9mo ago
> So, Lord have mercy on my soul if I have a new hire tell me "I don't know how to use the regular terminals. All I can use is VSCode's terminal." I think sometimes things should be hard, but I don't think termin
14.
by Tyriar 9mo ago
One of the things we should definitely action is hiding it in more places where it doesn't work well, that's one of the key pieces of feedback we got and is tracked in https://github.com/microsoft/vscode/
15.
by Tyriar 9mo ago
Hi from the VS Code team - I recently went into detail about why we did this in https://github.com/microsoft/vscode/issues/282268#issuecomme... . We believe it'll be beneficial overall and go a long way i
16.
by Tyriar 10mo ago
It's actually been the default since v1.55 which released early April 2021: https://code.visualstudio.com/updates/v1_55#_webgl-renderer-... Before that from v1.17 (~October 2017) it was using a 2d canvas context:
17.
by Tyriar 2y ago
I think it was always a Google product https://github.com/GoogleChrome/lighthouse/tree/9ff34c320811... . If I remember right it was an evolution of the page speed test site (can't remember exact name) of
18.
by Tyriar 2y ago
I work on VS Code. We have a feature for this exact problem that enforces a minimum contrast ratio of 4.5:1 via shifting the luminance of the foreground text by default https://code.visualstudio.com/docs/terminal/a
19.
by Tyriar 3y ago
I'm on the VS Code team and maintain xterm.js. Smooth scrolling in VS Code is primarily about animating scroll events such that scrolling with a mouse wheel doesn't just scroll an increment immediately but over a fixed time, updat
20.
by Tyriar 3y ago
I'm on the VS Code team and maintain xterm.js which is what Hyper's frontend is based on. There are actually multiple developments happening in this area. First, there's a contribution from the author of DomTerm which adds gr
21.
by Tyriar 4y ago
Sounds like they meant its good news if you're not a mosquito magnet?
22.
by Tyriar 4y ago
You can press f8 to view the problem in a "peek view" under the problem line, or view on the problems panel.
23.
by Tyriar 5y ago
For many games, idle games are a special case though, I don't think anyone who plays an idle game would want the logic loop to pause. They typically take a long time to play so minimizing and checking back every now and then is a very
24.
by Tyriar 5y ago
You could look up activation events on the website, I don't think we guarantee anything relating to order other than that. Generally the order in which they're activated shouldn't matter in practice.
25.
by Tyriar 5y ago
VS Code team member here. The diagram in the article is a little wrong, but the basics of it are: - The "main process" which manages the windows (renderer processes) - The renderer process" contains the UI thread for each win
26.
by Tyriar 5y ago
Const enums specifically are great, since they disappear on compile you can use them to internally document strings/numbers with verbose names/comments without the cost of a const variable that would appear after compilation. As f
27.
by Tyriar 5y ago
MS acquired that extension, Don works at MS now.
28.
by Tyriar 5y ago
MS dev here. Thanks for calling this out. I contacted the GH@MS admins to look into this and to consider adding some safeguards to the tooling so this doesn't happen in the future.
29.
by Tyriar 5y ago
MS dev here. I contacted the internal repo owners to bring this to their attention, people may be out for the holidays but I expect it to get fixed up soon.
30.
by Tyriar 5y ago
I used to care a lot more about code style, now when I get those feelings while reviewing I'll instead invest that effort into setting up a lint rule so it's the last time I need to make the comment.

More ›