7 ms·

I really appreciate the attention to detail in every little thing including the README. Very inspiring. This is a serious question for HN: Is it considered rud

I really appreciate the attention to detail in every little thing including the README. Very inspiring. This is a serious question for HN: Is it considered rude to make pull requests to fix grammar? The English is great, but is made more apparent in some locations (such as headers in the README) that it is a second language, but the first thing I thought to myself was "that'd be rude".

impostervt 12y ago
Just my opinion, but I don't think it would be rude. Even thought I KNOW it's not really relevant, I've caught myself trusting some projects less if the Readme isn't well written.
omahlama 12y ago
That sort of thing happens all the time on stackoverflow, where most of the users aren't native English speakers. Go for it!
akerl_ 12y ago
In my experience, one of the upsides of GitHub and similar services is that they drastically lower the process headache of merging patches. When merging a patch means getting it out of the email and applying it to your branch, confirming it's valid / what changed, running your tests, then merging and pushing up the new version, it's quick to see why single-character or grammar/spelling fixes can be a burden. With GitHub, I can see the PR, the diff, whether it'll merge cleanly, and whether my TravisCI tests pass right from the PR's page, and all I need to do is hit the Merge button. It makes me much more likely to review/merge PRs.
xomateix 12y ago
As a non native english speaker I would really appreciate any correction.
skywinder 12y ago
Yep. I know, my english is not well. So, I will much apreciate a PR with grammar fixes.
- scrapcode 12y ago
  Your English is just fine. Excellent, even, for being a second language.
- duaneb 12y ago
  In this case, you'd want 'good' instead of 'well'—your english is good and you speak english well.
  - skywinder 12y ago
    Good to know! :) Thanks!
evantahler 12y ago
I'm a native english speaker who just happens to be a terrible speller. I consider it a measure of project success when someone who isn't a native english speaker corrects me :D
tych0 12y ago
No, it's not rude. For me personally, I just think it's great that someone else was interested in the code. I would venture a guess that 95% of the ESL speakers I know just want to get better, and would love to be corrected.
kmfrk 12y ago
It's not rude; it just ideally needs its own section or priority setting so they don't appear on par with bug fixes and the like.
tessierashpool 12y ago
I do it all the time, most people seem to like it. I usually apologize for being "that guy," though, because I don't want anyone taking it personally.

impostervt 12y ago

Just my opinion, but I don't think it would be rude. Even thought I KNOW it's not really relevant, I've caught myself trusting some projects less if the Readme isn't well written.

omahlama 12y ago

That sort of thing happens all the time on stackoverflow, where most of the users aren't native English speakers. Go for it!

akerl_ 12y ago

In my experience, one of the upsides of GitHub and similar services is that they drastically lower the process headache of merging patches. When merging a patch means getting it out of the email and applying it to your branch, confirming it's valid / what changed, running your tests, then merging and pushing up the new version, it's quick to see why single-character or grammar/spelling fixes can be a burden. With GitHub, I can see the PR, the diff, whether it'll merge cleanly, and whether my TravisCI tests pass right from the PR's page, and all I need to do is hit the Merge button. It makes me much more likely to review/merge PRs.

xomateix 12y ago

As a non native english speaker I would really appreciate any correction.

skywinder 12y ago

Yep. I know, my english is not well. So, I will much apreciate a PR with grammar fixes.

scrapcode 12y ago
Your English is just fine. Excellent, even, for being a second language.
duaneb 12y ago
In this case, you'd want 'good' instead of 'well'—your english is good and you speak english well.
- skywinder 12y ago
  Good to know! :) Thanks!

evantahler 12y ago

I'm a native english speaker who just happens to be a terrible speller. I consider it a measure of project success when someone who isn't a native english speaker corrects me :D

tych0 12y ago

No, it's not rude. For me personally, I just think it's great that someone else was interested in the code. I would venture a guess that 95% of the ESL speakers I know just want to get better, and would love to be corrected.

kmfrk 12y ago

It's not rude; it just ideally needs its own section or priority setting so they don't appear on par with bug fixes and the like.

tessierashpool 12y ago

I do it all the time, most people seem to like it. I usually apologize for being "that guy," though, because I don't want anyone taking it personally.