14 ms·
My attitude has always been that code review is best thought of as the gate where code goes from being owned by the author to being owned by the team or project
by sjburt 3mo ago
My attitude has always been that code review is best thought of as the gate where code goes from being owned by the author to being owned by the team or project. The code I'm reviewing is not your code, it is code that is about to become our code.
Maintainability is a major factor in that, of course.
- dude250711 3mo agoSuch a luxury, I am envious! Our team started using AI, so I switched to a simple method: no comments, and a binary "is this batshit crazy or passable" approval decision rule. Saving myself time and sanity.
- acedTrex 3mo agoYep, without a decent team culture this is what LLMs force, the slop deluge is just overwhelming without leadership asserting "no, stop" Ultimately you just let bugs through because the alternative is spend an inordinate amount of time communicating with someones claude through PR comments about what the shape should be. Career was fun while it lasted. I suppose its a blessing a to get to do a job that you enjoyed for as many years as I did.
- morganherlocker 3mo agoDisapprove and ask for a call where the author must verbally explain the changes to receive approval? This seems like a solvable problem, and one that already existed in repos with many contributors of varying skill (open source, bigco with lots of interns). Letting bugs through is an even bigger time sink.
- tarentel 3mo agoIf you work at a small shop that may work. Everyone is 100xer now thanks to AI. No one has time to actually go through all this nonsense, not even the people who "wrote" it. Approve and pray you're not the one on call is the only viable strategy for some.
- acedTrex 3mo agoIt comes down to culture on the team, if you think your leadership will allow that/you won't get a bad perf review for doing it go for it. That is sadly not a lot of peoples reality.
- Sharlin 3mo agoIn other words, AI code is owned by nobody.
- kibwen 3mo agoIt's not innacurate to say that AI code becomes legacy code the instant it's merged.
- randusername 3mo agoAI code is owned by owners and society is figuring out in real-time if code has some inherent value without humans that understand it. I'll be really interested to follow what comes out of the Bun team.
- nijave 3mo agoTragedy of the commons
- stronglikedan 3mo agoAI is just another tool in a developer's toolbox. The developer owns their output, regardless of the tools they used. Same as it always has been.