5 ms·
Having seen some of the diffs, it's already going wrong in my view.
by debugnik 4mo ago
Having seen some of the diffs, it's already going wrong in my view.
- adityashankar 4mo agoCurious can you elaborate on this?
- surajrmal 4mo agoIf most of the glaring problems are addressed (massive unsafe usage), and metrics show improvement (less crashes), then did it really go wrong? The fact the code is not idiomatic is less interesting, because that can be addressed incrementally. Let's wait 3 months and reflect.
- debugnik 4mo agoI'm thinking regressions and broken tests. Bun is already known to segfault a lot and their existing tests were rather lackluster, the Rust port being just as unsafe would be the least of their problems.
- ajyoon 4mo agoThis assumes that the memory safety bugs in the unsafe Rust port are the same as the Zig codebase. A total rewrite with so little review is virtually guaranteed to introduce many new bugs which very well may be more severe than the old bugs.