5 ms·

We're required to have code review as part of our SOC2 process, and I assume automated agents wouldn't count. The other end of the spectrum is linting and test

by tyrw 2y ago

We're required to have code review as part of our SOC2 process, and I assume automated agents wouldn't count. The other end of the spectrum is linting and tests, which catch errors before review. Does Ellipsis have a role between these two? If so, what is the role?

hunterbrooks 2y ago
Ellipsis increases the quality of code a developer brings to their teammates, meaning fewer PR comments, meaning the team ships faster. It's not a replacement for human review. It's most often used by the PR author after a self review but before asking for reviews from human teammates. Ellipsis will use your existing lint/test commands when making code changes. For example, you can leave a comment on a PR that says "@ellipsis-dev fix the assertion in the failing unit test" and Ellipsis will run the tests, observe the failure, make the code change, confirm the tests pass, lint-fix the code, and push a commit or new PR
- luskira 2y ago
  This is a very interesting usecase
- thih9 2y ago
  > It's most often used by the PR author after a self review Why run it as part of a PR then? I'd prefer to run a tool like this before a PR is even open, and ideally on my local machine.
  - hunterbrooks 2y ago
    The product works on draft PR's too, but not on local. Sometimes reviewers rope in Ellipsis by asking questions (we also support natural language Q&A about a PR) or by having a design discussion via GH comments and then assigning the change to Ellipsis
- userbinator 2y ago
  increases the quality of code a developer brings to their teammates Only if they're already below average.
  - hunterbrooks 2y ago
    No way, anyone can make silly mistakes. Ellipsis is a 2nd pair of eyes to catch stuff like that
- wiseowise 2y ago
  > Ellipsis increases the quality of code a developer brings to their teammates, meaning fewer PR comments, meaning the team ships faster. Interesting. Got any numbers how it affects team velocity?
  - hunterbrooks 2y ago
    Unfortunately not. We’re early - all our data is qualitative. But we know we need hard numbers, so we’re working on it. We don’t want to sell a novelty, the product needs to actually save time

by tyrw 2y ago

hunterbrooks 2y ago

Ellipsis increases the quality of code a developer brings to their teammates, meaning fewer PR comments, meaning the team ships faster. It's not a replacement for human review. It's most often used by the PR author after a self review but before asking for reviews from human teammates. Ellipsis will use your existing lint/test commands when making code changes. For example, you can leave a comment on a PR that says "@ellipsis-dev fix the assertion in the failing unit test" and Ellipsis will run the tests, observe the failure, make the code change, confirm the tests pass, lint-fix the code, and push a commit or new PR

luskira 2y ago
This is a very interesting usecase
thih9 2y ago
> It's most often used by the PR author after a self review Why run it as part of a PR then? I'd prefer to run a tool like this before a PR is even open, and ideally on my local machine.
- hunterbrooks 2y ago
  The product works on draft PR's too, but not on local. Sometimes reviewers rope in Ellipsis by asking questions (we also support natural language Q&A about a PR) or by having a design discussion via GH comments and then assigning the change to Ellipsis
userbinator 2y ago
increases the quality of code a developer brings to their teammates Only if they're already below average.
- hunterbrooks 2y ago
  No way, anyone can make silly mistakes. Ellipsis is a 2nd pair of eyes to catch stuff like that
wiseowise 2y ago
> Ellipsis increases the quality of code a developer brings to their teammates, meaning fewer PR comments, meaning the team ships faster. Interesting. Got any numbers how it affects team velocity?
- hunterbrooks 2y ago
  Unfortunately not. We’re early - all our data is qualitative. But we know we need hard numbers, so we’re working on it. We don’t want to sell a novelty, the product needs to actually save time