6 ms·

Would help if they mention what a "CL" is somewhere before using it ubiquitously

enjoyyourlife 7y ago
They do define it, see https://google.github.io/eng-practices/ https://google.github.io/eng-practices/. It means "change list."
- eddieh 7y ago
  Where does that define CL?
  - x3n0ph3n3 7y ago
    Under "Terminology"
    - eddieh 7y ago
      My bad. For some reason I was looking at this https://google.github.io/eng-practices/review/developer/ https://google.github.io/eng-practices/review/developer/ after opening a new tab.
deleted 7y ago
[deleted]
jdm2212 7y ago
It refers to "changelist". Google uses a Perforce-like VCS internally, and they kept the Perforce terminology: https://www.perforce.com/perforce/doc.051/manuals/p4guide/07_changelists.html https://www.perforce.com/perforce/doc.051/manuals/p4guide/07...
- jonny_eh 7y ago
  aka "Pull Request" in Github parlance.
  - hota_mazi 7y ago
    aka "Merge Request" in Gitlab vernacular (which makes more sense than "pull request" in my opinion).
    - cpeterso 7y ago
      A Perforce changelist is more like a git commit than a GitHub pull request.
      - jefftk 7y ago
        The way Google uses it, a "CL" means both "a thing you sent out for pre-commit review" and "a submitted change". It's very similar to a GitHub PR, if you use a master branch and always squash your PRs when merging to master.
    - aledalgrande 7y ago
      aka "patch" for the Linux kernel development community
      - xixixao 7y ago
        aka "diff" or "revision" at FB .)
        o10449366 7y ago
        aka "CR" or "Change Request" at Amazon
    - sanderjd 7y ago
      Yeah, merge request seems like the best terminology of the ones I've seen.
atsaloli 7y ago
It's defined on the front page, <https://google.github.io/eng-practices/> https://google.github.io/eng-practices/>, under Terminology: CL: Stands for “changelist,” which means one self-contained change that has been submitted to version control or which is undergoing code review. Other organizations often call this a “change” or a “patch.”

They do define it, see https://google.github.io/eng-practices/ https://google.github.io/eng-practices/. It means "change list."

eddieh 7y ago
Where does that define CL?
- x3n0ph3n3 7y ago
  Under "Terminology"
  - eddieh 7y ago
    My bad. For some reason I was looking at this https://google.github.io/eng-practices/review/developer/ https://google.github.io/eng-practices/review/developer/ after opening a new tab.

deleted 7y ago

[deleted]

jdm2212 7y ago

It refers to "changelist". Google uses a Perforce-like VCS internally, and they kept the Perforce terminology: https://www.perforce.com/perforce/doc.051/manuals/p4guide/07_changelists.html https://www.perforce.com/perforce/doc.051/manuals/p4guide/07...

jonny_eh 7y ago
aka "Pull Request" in Github parlance.
- hota_mazi 7y ago
  aka "Merge Request" in Gitlab vernacular (which makes more sense than "pull request" in my opinion).
  - cpeterso 7y ago
    A Perforce changelist is more like a git commit than a GitHub pull request.
    - jefftk 7y ago
      The way Google uses it, a "CL" means both "a thing you sent out for pre-commit review" and "a submitted change". It's very similar to a GitHub PR, if you use a master branch and always squash your PRs when merging to master.
  - aledalgrande 7y ago
    aka "patch" for the Linux kernel development community
    - xixixao 7y ago
      aka "diff" or "revision" at FB .)
      - o10449366 7y ago
        aka "CR" or "Change Request" at Amazon
  - sanderjd 7y ago
    Yeah, merge request seems like the best terminology of the ones I've seen.

atsaloli 7y ago

It's defined on the front page, <https://google.github.io/eng-practices/> https://google.github.io/eng-practices/>, under Terminology: CL: Stands for “changelist,” which means one self-contained change that has been submitted to version control or which is undergoing code review. Other organizations often call this a “change” or a “patch.”