6 ms·
Why should anyone use this, instead of just using a Redis client, the `cluster` module, and a WebSocket server directly? It's only 251 lines of code as of writi
by sapeien 10y ago
Why should anyone use this, instead of just using a Redis client, the `cluster` module, and a WebSocket server directly? It's only 251 lines of code as of writing, which is partly spent on trivia such as a linked list implementation, a string hashing function, and some console messages. There is a whopping total of 23 lines of test code for the linked list implementation.
Also, did you really hardcode credentials to some hosted Redis instance somewhere? https://github.com/team-emt/razorframe/blob/e35004f7f2915275f81d6133455fc95293c88665/lib/Razorframe.js#L10 https://github.com/team-emt/razorframe/blob/e35004f7f2915275... (I'd rewrite git history if I were you)
- sotkrab 10y agoHey this is Michael, one of the co-creators of Razorframe. We're currently hosting a redis server for devs to use during the prototyping phase. Those who are moving into production will need to host their own, but we're happy to share with the community. We're adding information to our documentation to this effect. Great catch and thanks for reviewing our code!
- mmaunder 10y agoAhem. https://github.com/team-emt/rz_demo/blob/master/server/database.js https://github.com/team-emt/rz_demo/blob/master/server/datab...
- mmaunder 10y agoYeah. https://github.com/team-emt/rz_demo/commit/59ee149a50f25d13fe3414bb2818b06e286da634 https://github.com/team-emt/rz_demo/commit/59ee149a50f25d13f... Rewrite history, as @sapeien suggested.