7 ms·
> The code comes back to us, and we have to redo it -- there's nothing good about this. Implement code review and start rejecting their pull requests with cons
by califield 12y ago
> The code comes back to us, and we have to redo it -- there's nothing good about this.
Implement code review and start rejecting their pull requests with constructive criticism and mentoring.
- djmill 12y agoIt seems to be an issue because the offshore folks are saying they do code reviews... but when we review the code, it's clear that they're not - or if they are, they have no idea what's good code and what's bad code. The main issue is that I need to be mentored. It's my first full-time job and I shouldn't be the one mentoring anyone unless they're an intern with no knowledge of enterprise software development.