7 ms·

Hi Go team, if you want an alternative for Gerrit code review, you can also use http://review.ninja http://review.ninja. It's also open source, so you are welc

Hi Go team, if you want an alternative for Gerrit code review, you can also use http://review.ninja http://review.ninja. It's also open source, so you are welcome to contribute. Cheers, Mitch

skj 12y ago
Took a brief look at the front page. - No side-by-side diffs? Didn't see any in screen shots. - The scopes asked for seem very broad. I may be confused, but it seemed like it was asking for write access to all repositories, public and private. I have access to several private repos (but I don't own them) for which this is unacceptable. If the scope is limited to the ones under github.com/me then it's not as big a deal... In any case, the scary scope list prevented me from experimenting.
- Spitfire777 12y ago
  Hi skj! - What do you exactly mean by side-by-side diff? Currently you have diff view between the current HEAD of the Pull Request branch by the base commit. - Yes, that is true. This is a known issue mentioned by others and there is definitely a need to fix that. ReviewNinja comes from the GitHub Enterprise context, where you usually can trust the internal tool offering, that's why we kept it simple with the permissions in the first place. Thank you for the feedback!
  - skj 12y ago
    Here's a screenshot of some side-by-side diff action: https://fr.atlassian.com/wac/software/fisheye/overview/screenshot-tour/featureItems/0/featureItems/0/imageBinary/fisheye-side-by-side-diff.png https://fr.atlassian.com/wac/software/fisheye/overview/scree... Basically, it let's you look at the old code, or look at the new code, or see how they're different, all at the same time. Inline diffs (github-style) require you to keep a context as you scan through code, and it makes it harder to keep everything in your head.
pridkett 12y ago
Review Ninja is beautiful, but at it's core, it's just slightly more nice stuff on top of pull requests. It can't address the issues such as being able to edit someone else's pull request as part of a code review, can it?
- Spitfire777 12y ago
  Hi pridkett! Anything pushed to the branch of a pull request is an edit on the pull request. Once something new is pushed on to the pull request, the voting in ReviewNinja needs to be repeated. Furthermore, Issues linked to a commit will be linked to all new commits by Review.Ninja automatically, as long as the issue isn't solve. You only merge, once all issues are solved / it is save to merge. Cheers, Mitch
McGlockenshire 12y ago
How much do we have to bribe you for Bitbucket integration?
- Spitfire777 12y ago
  We will work for cookies! :) jk We are very open for cool new ideas, features and also contributions on our GitHub repo: https://github.com/reviewninja/review.ninja https://github.com/reviewninja/review.ninja ReviewNinja comes from the GitHub Enterprise context (as we use GitHub Enterprise in our company) and we want to offer an open source code review tool for both GitHub.com and GitHub Enterprise. Bitbucket is awesome! But I think if we want to support on premise installations with Review.Ninja, BitBucket support would be overkill. Cheers, Mitch

Hi Go team, if you want an alternative for Gerrit code review, you can also use http://review.ninja http://review.ninja. It's also open source, so you are welcome to contribute. Cheers, Mitch

skj 12y ago

Took a brief look at the front page. - No side-by-side diffs? Didn't see any in screen shots. - The scopes asked for seem very broad. I may be confused, but it seemed like it was asking for write access to all repositories, public and private. I have access to several private repos (but I don't own them) for which this is unacceptable. If the scope is limited to the ones under github.com/me then it's not as big a deal... In any case, the scary scope list prevented me from experimenting.

Spitfire777 12y ago
Hi skj! - What do you exactly mean by side-by-side diff? Currently you have diff view between the current HEAD of the Pull Request branch by the base commit. - Yes, that is true. This is a known issue mentioned by others and there is definitely a need to fix that. ReviewNinja comes from the GitHub Enterprise context, where you usually can trust the internal tool offering, that's why we kept it simple with the permissions in the first place. Thank you for the feedback!
- skj 12y ago
  Here's a screenshot of some side-by-side diff action: https://fr.atlassian.com/wac/software/fisheye/overview/screenshot-tour/featureItems/0/featureItems/0/imageBinary/fisheye-side-by-side-diff.png https://fr.atlassian.com/wac/software/fisheye/overview/scree... Basically, it let's you look at the old code, or look at the new code, or see how they're different, all at the same time. Inline diffs (github-style) require you to keep a context as you scan through code, and it makes it harder to keep everything in your head.

pridkett 12y ago

Review Ninja is beautiful, but at it's core, it's just slightly more nice stuff on top of pull requests. It can't address the issues such as being able to edit someone else's pull request as part of a code review, can it?

Spitfire777 12y ago
Hi pridkett! Anything pushed to the branch of a pull request is an edit on the pull request. Once something new is pushed on to the pull request, the voting in ReviewNinja needs to be repeated. Furthermore, Issues linked to a commit will be linked to all new commits by Review.Ninja automatically, as long as the issue isn't solve. You only merge, once all issues are solved / it is save to merge. Cheers, Mitch

McGlockenshire 12y ago

How much do we have to bribe you for Bitbucket integration?

Spitfire777 12y ago
We will work for cookies! :) jk We are very open for cool new ideas, features and also contributions on our GitHub repo: https://github.com/reviewninja/review.ninja https://github.com/reviewninja/review.ninja ReviewNinja comes from the GitHub Enterprise context (as we use GitHub Enterprise in our company) and we want to offer an open source code review tool for both GitHub.com and GitHub Enterprise. Bitbucket is awesome! But I think if we want to support on premise installations with Review.Ninja, BitBucket support would be overkill. Cheers, Mitch