5 ms·

Why don't you all "deserves better comment" people send a patch?

vanderZwan 13y ago
Yes, this opportunity to make a reference to De La Soul should not be wasted!
_pmf_ 13y ago
> Why don't you all "deserves better comment" people send a patch? Trying to get a patch into Linux as a new developer without personally knowing one of the (sub-)lieutenants is a futile exercise.
- ah- 13y ago
  That doesn't match my experience at all. Find the maintainer of the relevant subsystem, talk to them via mail or IRC about what's bugging you and how to improve it, implement it, send a patch and it will most likely be accepted. Where I have had difficulties getting something accepted is if your patch might cause problems later or doesn't solve the problem in a way that aligns with the vision of the maintainer. But while that might be annoying as a developer that wants a problem fixed now, I'd say that it's probably for the better of the whole kernel.
  - _pmf_ 13y ago
    > But while that might be annoying as a developer that wants a problem fixed now, I'd say that it's probably for the better of the whole kernel. I agree in general. However, the Embedded Linux world suffers from severe fragmentation and duplicate and/or incompatible work in part due to this policy (the greater good). The ARM platform has been consolidated a bit due to the involvement of very large players, but on the PowerPC side, things are pretty dim.
- apaprocki 13y ago
  I did it (and repeated a few times) and I didn't know anyone. I did it by reading about the process, formatting my patch correctly, and sending it to the appropriate list. If it were so difficult, Linux would not be a success. Now, just like other large projects, maintainers might dislike comment-only nit patches, but if it objectively increases readability it might work.
  - army 13y ago
    It's probably easier to get it in when you're solving a real problem.
- adobriyan 13y ago
  > Trying to get a patch into Linux as a new developer without [personally] knowing one of the (sub-)lieutenants is a futile exercise. You're totally wrong about "personal" part.

Yes, this opportunity to make a reference to De La Soul should not be wasted!

_pmf_ 13y ago

> Why don't you all "deserves better comment" people send a patch? Trying to get a patch into Linux as a new developer without personally knowing one of the (sub-)lieutenants is a futile exercise.

ah- 13y ago
That doesn't match my experience at all. Find the maintainer of the relevant subsystem, talk to them via mail or IRC about what's bugging you and how to improve it, implement it, send a patch and it will most likely be accepted. Where I have had difficulties getting something accepted is if your patch might cause problems later or doesn't solve the problem in a way that aligns with the vision of the maintainer. But while that might be annoying as a developer that wants a problem fixed now, I'd say that it's probably for the better of the whole kernel.
- _pmf_ 13y ago
  > But while that might be annoying as a developer that wants a problem fixed now, I'd say that it's probably for the better of the whole kernel. I agree in general. However, the Embedded Linux world suffers from severe fragmentation and duplicate and/or incompatible work in part due to this policy (the greater good). The ARM platform has been consolidated a bit due to the involvement of very large players, but on the PowerPC side, things are pretty dim.
apaprocki 13y ago
I did it (and repeated a few times) and I didn't know anyone. I did it by reading about the process, formatting my patch correctly, and sending it to the appropriate list. If it were so difficult, Linux would not be a success. Now, just like other large projects, maintainers might dislike comment-only nit patches, but if it objectively increases readability it might work.
- army 13y ago
  It's probably easier to get it in when you're solving a real problem.
adobriyan 13y ago
> Trying to get a patch into Linux as a new developer without [personally] knowing one of the (sub-)lieutenants is a futile exercise. You're totally wrong about "personal" part.