5 ms·

So I use github enterprise and use the review tool a lot. It has improved our overall code review experience, but there is a few things which have proved probl

by Newky 13y ago

So I use github enterprise and use the review tool a lot. It has improved our overall code review experience, but there is a few things which have proved problematic and even have caused major headaches in the last year or so. 1. No Side by Side diffs. 2. Pushing new commits will often collapse conversations from the review. (i.e these conversations are folded) Really, I want some way to look at my PR and say hey I've addressed all the comments on this pull request, and I am good to merge. This is not even getting into what happens if you rebase your branch and then force a push to the remote.

stu_k 13y ago
For problem 1, I use this extension https://chrome.google.com/webstore/detail/octosplit/mnkacicafjlllhcedhhphhpapmdgjfbb https://chrome.google.com/webstore/detail/octosplit/mnkacica... It's not quite the side-by-side diff that I want (like Meld http://meldmerge.org/ http://meldmerge.org/) but it does help.
jleader 13y ago
When things are messy enough that I want to rebase a branch, I generally create a new branch and new PR, and close the old PR with a comment linking to the new PR. I also put a link to the old PR in the description of the new one, so people can easily go back and look at the old discussion. In other words, rebasing is a big enough change that I feel it's appropriate to restart the PR.
- taeric 13y ago
  If you are linking the requests with a comment on each end, I'm not sure I see the benefit to just pushing the rebase into an open request. Is there a real difference?
spicyj 13y ago
At Khan Academy we use http://phabricator.org/ http://phabricator.org/ and I absolutely love it. It solves both of your named problems and a handful of others.
sarm2005 13y ago
I wrote a Chrome extension that supports side-by-side, syntax highlighting, and some other stuff: https://chrome.google.com/webstore/detail/github-side-by-side-diffs/ahamcncifjblaomhphpfpopppadboiin https://chrome.google.com/webstore/detail/github-side-by-sid.... It draws a lot of inspiration from having used Phabricator. For anyone interested, the source code is at: https://github.com/mduan/Github-Enhancement-Suite/ https://github.com/mduan/Github-Enhancement-Suite/.

by Newky 13y ago

stu_k 13y ago

For problem 1, I use this extension https://chrome.google.com/webstore/detail/octosplit/mnkacicafjlllhcedhhphhpapmdgjfbb https://chrome.google.com/webstore/detail/octosplit/mnkacica... It's not quite the side-by-side diff that I want (like Meld http://meldmerge.org/ http://meldmerge.org/) but it does help.

jleader 13y ago

When things are messy enough that I want to rebase a branch, I generally create a new branch and new PR, and close the old PR with a comment linking to the new PR. I also put a link to the old PR in the description of the new one, so people can easily go back and look at the old discussion. In other words, rebasing is a big enough change that I feel it's appropriate to restart the PR.

taeric 13y ago
If you are linking the requests with a comment on each end, I'm not sure I see the benefit to just pushing the rebase into an open request. Is there a real difference?

spicyj 13y ago

At Khan Academy we use http://phabricator.org/ http://phabricator.org/ and I absolutely love it. It solves both of your named problems and a handful of others.

sarm2005 13y ago

I wrote a Chrome extension that supports side-by-side, syntax highlighting, and some other stuff: https://chrome.google.com/webstore/detail/github-side-by-side-diffs/ahamcncifjblaomhphpfpopppadboiin https://chrome.google.com/webstore/detail/github-side-by-sid.... It draws a lot of inspiration from having used Phabricator. For anyone interested, the source code is at: https://github.com/mduan/Github-Enhancement-Suite/ https://github.com/mduan/Github-Enhancement-Suite/.