5 ms·

Seriously? Fire someone over rejecting a pull request that modified comments of code to change pronouns somewhere? Then go on a rant about how this person lack

Seriously? Fire someone over rejecting a pull request that modified comments of code to change pronouns somewhere? Then go on a rant about how this person lacks 'empathy' and should not have a job at your company. Don't get me wrong, I am for gender neutral pronouns wherever possible. But to advocate firing someone over such a trivial social issue is silly. Maybe this person was concerned with technical issues within the actual code, and could care less about the political correctness surrounding some comments.

fader 13y ago
I think the 'firing' comment was over reverting the commit that fixed the gendered pronouns. I.e. this person changed the pronouns back to the gendered version after the non-gendered ones were committed. That is a bit more than the initial rejection of the patch.
- bbitmaster 13y ago
  actually, that's not what happened at all. Read the response of the guy who rejected it here: https://github.com/joyent/libuv/pull/1015#issuecomment-29538615 https://github.com/joyent/libuv/pull/1015#issuecomment-29538... Hi all, let me try to clear up a few things. Why I rejected the pull request. Us maintainers tend to reject tiny doc changes because they're often more trouble than they're worth. You have to collect and check the CLA, it makes git blame less effective, etc. That's why the usual approach to such pull requests is 'no, unless' - in this case the 'unless' should probably have applied. To me as a non-native speaker, the difference between 'him' and 'them' seems academic but hey, if it gets us scores of female contributors, who am I to object? Why I reverted the commit. In hindsight, I should have given Isaac the benefit of the doubt because I don't doubt that he acted with the best of intentions. On the other hand, if another committer jumped the line like that, I would have done the same thing. We have procedures in place and no one is exempt from them. To the people that felt it necessary to call me a misogynist: I volunteer in a mentorship program that gets young people - especially young women - involved in technology. How many of you go out and actively try to increase the number of women in the field? I'm probably going to step back from libuv and node.js core development. I do it more out a sense of duty than anything else. If this is what I have to deal with, then I'd just as rather do something else. Hope that clears things up. Thanks.

fader 13y ago

I think the 'firing' comment was over reverting the commit that fixed the gendered pronouns. I.e. this person changed the pronouns back to the gendered version after the non-gendered ones were committed. That is a bit more than the initial rejection of the patch.

bbitmaster 13y ago
actually, that's not what happened at all. Read the response of the guy who rejected it here: https://github.com/joyent/libuv/pull/1015#issuecomment-29538615 https://github.com/joyent/libuv/pull/1015#issuecomment-29538... Hi all, let me try to clear up a few things. Why I rejected the pull request. Us maintainers tend to reject tiny doc changes because they're often more trouble than they're worth. You have to collect and check the CLA, it makes git blame less effective, etc. That's why the usual approach to such pull requests is 'no, unless' - in this case the 'unless' should probably have applied. To me as a non-native speaker, the difference between 'him' and 'them' seems academic but hey, if it gets us scores of female contributors, who am I to object? Why I reverted the commit. In hindsight, I should have given Isaac the benefit of the doubt because I don't doubt that he acted with the best of intentions. On the other hand, if another committer jumped the line like that, I would have done the same thing. We have procedures in place and no one is exempt from them. To the people that felt it necessary to call me a misogynist: I volunteer in a mentorship program that gets young people - especially young women - involved in technology. How many of you go out and actively try to increase the number of women in the field? I'm probably going to step back from libuv and node.js core development. I do it more out a sense of duty than anything else. If this is what I have to deal with, then I'd just as rather do something else. Hope that clears things up. Thanks.