5 ms·

It looks like this is leaking the room name to Google Analytics. After thinking about this more, I'm going to go ahead and remove that. I should be able to moni

It looks like this is leaking the room name to Google Analytics. After thinking about this more, I'm going to go ahead and remove that. I should be able to monitor the server itself to make sure it isn't getting overloaded.

erbbysam 13y ago
removed - https://github.com/erbbysam/webRTCCopy/commit/c1f35404414d633ea211050ff5e1085fc8d92308 https://github.com/erbbysam/webRTCCopy/commit/c1f35404414d63...
- zz1 13y ago
  Great!
- Gnewt 13y ago
  Are you hosting the site through Github Pages?
  - erbbysam 13y ago
    No, I currently just manually keep the site in sync with the repository. Not exactly the most professional system but it got the job done. I'm going to look into that(not sure exactly how it works, but I do need to keep a node.js server running as well for webrtc negotiation) , as well as potentially just installing git on the server and have it sync up to the repository.
mike-cardwell 13y ago
Even if Google weren't currently sucking up this information, it would still have been a wise decision to remove it. They can change their JavaScript at any point without you noticing and start logging it. Malicious intent not required.