7 ms·
I appreciate that you decided to open-source this project. I do have a few (hopefully) constructive criticisms to make: 1. Using aliases the reindex with near
by brunomiranda 13y ago
I appreciate that you decided to open-source this project. I do have a few (hopefully) constructive criticisms to make:
1. Using aliases the reindex with near zero downtime is very clever, mad props to Jaroslav Kalistsuk
2. Tire is excellent, I am glad you didn't try to reinvent the wheel here, please keep it that way.
3. Conversion based score boosting, although clever is flawed. Hardcoding values https://github.com/ankane/searchkick/blob/master/lib/searchkick/search.rb#L17 https://github.com/ankane/searchkick/blob/master/lib/searchk... is convoluted. You should consider providing a more flexible DSL to customize how conversion based score is calculated.
4. Analyzers https://github.com/ankane/searchkick/blob/master/lib/searchkick/reindex.rb#L42 https://github.com/ankane/searchkick/blob/master/lib/searchk... are poorly named and do not represent what they do.
Again, this is very nice for version 0.1.2