6 ms·
It looks pretty well thought-out, which is a big +1 when I'm framework shopping. However: use pushState/replaceState! Or at least fix your buggy back button. Yo
by anondesign 13y ago
It looks pretty well thought-out, which is a big +1 when I'm framework shopping. However: use pushState/replaceState! Or at least fix your buggy back button. Your hash-based navigation totally breaks the back button to a point where I can't believe you shipped this.
- anondesign 13y agoAlso: don't forget to use manifest files to concatenate your compiled CSS :)
- mistercow 13y agoOr you could just use LESS and @import your styles. LESS @import for other LESS files works much like C's #include, rather than simply converting to a CSS @import line.
- anondesign 13y agoHe's using rails, so he can use SASS (which personally I like better than LESS, but they accomplish the same things). Manifest files are better though, because with LESS's @import, you might import more files than you actually want. I believe you also have the recursive import issue, just like C. Manifest files give you more granularity by existing outside of the actual stylesheet.
- mikermcneil 13y agoThanks for the bug report! In particular, what back button issues were you having? I can't replicate any issues just now, but feel free to submit a PR if you see a fix. Shipping a customer site is way different than "shipping" the website for an open-source framework. Unfortunately, we don't get paid to work on Sails, and we're completely bootstrapped, so we only get to work on stuff like the public-facing website when we get spare time.