5 ms·
Looks awesome! Great idea and execution. I tweeted it at Jalen Rose and Bill Simmons. Minor things: - You're throwing a bunch of log statements right now. Mig
by mattkahl 13y ago
Looks awesome! Great idea and execution. I tweeted it at Jalen Rose and Bill Simmons.
Minor things:
- You're throwing a bunch of log statements right now. Might be taking down the javascript in IE (I didn't see if you wrapped `console.log`).
- Remember, `this.$el` can replace `$(this.el)` (gotta love those convenience methods, I see you're using `this.$(selector)`).
- Also, UnderscoreJS provides `_.isUndefined` and `_.has` which is a little nicer than the `typeof foo.bar !== undefined` test.
- billcurt 13y agoWow, thank you. To be honest I'm quite new to js, especially backbone and those other util libs like underscore. Really appreciate the CR, will fix shortly.