5 ms·
> Just the date fields is a hilarious example of why I'm skeptical. Python (babel.date) and Javascript (the browser's locale) both have locale-aware date render
by patrickmay 1mo ago
> Just the date fields is a hilarious example of why I'm skeptical. Python (babel.date) and Javascript (the browser's locale) both have locale-aware date rendering. Using a library for country-based date and time parsing would have eliminated ~12 country-specific change sites... but instead we got `is_uk` and raw date format strings (`%d/%m/%y`) in-line inside already-enormous functions. Also, at a meta level, the backend code shouldn't usually be formatting the dates (data export may be an exception), we should be sending ISO dates and having the frontend format the code if anyone gives a crap.
Did you reject the PR or is that not a career-enhancing approach in your organization?
- ianmarcinkowski 1mo agoI've worked with my teammate to see why this is suboptimal and negotiated a lot of concessions. I didn't re-review the code before we pushed it to staging for QA to test over the weekend... I'm worried about what I'll find when I look on Monday.