8 ms·
sendfile(2) and io.ReaderFrom both return the number of bytes transmitted. The issue is that users are unaware of (or forget about) the optional interface upgra
by flakes 2mo ago
sendfile(2) and io.ReaderFrom both return the number of bytes transmitted. The issue is that users are unaware of (or forget about) the optional interface upgrades and fail to define all the methods required for interface upgrades on their wrapper structs. You can definitely make a counting reader with a minimal performance loss, but the proper solution is less obvious than it ideally should be.
- drivebyhooting 2mo agoIsn’t this a symptom of structural/duck typing where interfaces are not declared? In Java for all its faults this wouldn’t happen because you’d be forced to implement all the interfaces.
- flakes 2mo ago> Isn’t this a symptom of structural/duck typing where interfaces are not declared Yes, essentially duck typing. See https://github.com/golang/go/blob/65504872cbca64d77f45828409f5c8c59bf23d54/src/io/io.go#L407-L416 https://github.com/golang/go/blob/65504872cbca64d77f45828409... The logic uses a type assertion to safely verify if the value backing the provided io.Reader interface also implements the io.ReaderFrom interface. If it matches, then it will use the more efficient implementation if rf, ok := dst.(ReaderFrom); ok { return rf.ReadFrom(src) } > In Java for all its faults this wouldn’t happen because you’d be forced to implement all the interfaces. I don't think I would go that far. In Java, many libraries make heavy use of the `instanceof` keyword, which is more or less the same as Go type assertions.
- pjmlp 2mo agoYes, but contrary to Go, if you change an interface it will be a compiler error if additional methods are missing, unless they have default implementations. In Java type assertions are mostly used when writing code pre-generics style, like downcasting from a common subclasse into the actual implementation, not to see if an interface is supported, as it is a given from the type system.
- ericpauley 2mo agoIt’s pretty common to type check interface implementations in Go using package-level casts.
- pjmlp 2mo agoI know, it is yet another language hack, just like the iota/const dance, instead of proper language constructs.
- flakes 2mo agoHow is a package level interface check a “language hack”? They are straight forward and provide a user the same compile time guarantees as the Java implements keyword.
- pjmlp 2mo agoBecause they are a workaround for what should be a language feature in first place, just like on ML languages to type check structural types.
- flakes 2mo agoWhat exactly isn’t a language feature? Or do you have issues with semantics? var _ Foo = (*Bar)(nil) The statement asserts that Bar struct pointers are assignable to a Foo interface. I do agree it’s not as clean looking as the Java implements keyword, but it’s already a fairly terse pattern and IMO the inconvenience does not justify introducing new language syntax.