6 ms·
It does seem like a serious tripping point. I took a quick look at "containedctx" and it seems like for this case, it would almost be backwards: it would flag
by compumike 3mo ago
It does seem like a serious tripping point.
I took a quick look at "containedctx" and it seems like for this case, it would almost be backwards: it would flag the (not-memory-leaking) struct-stored "status.ctx", but wouldn't flag when there is a stored "status.cancelFn" only (which resulted in the memory leak).
Could Go implement a runtime leaked-context detector, like the data race detector? https://go.dev/doc/articles/race_detector https://go.dev/doc/articles/race_detector
- cyberax 3mo agoThis actually is possible now. Contexts are now garbage-collectible, even if cancel() is not called. In this case, the cancel() function was preventing the collection. But I think it can be changed to hold a weak reference instead. The overhead is too large to run it normally, but it should be OK for something like the race detector.