6 ms·
Do you add these into the code or into the review itself? I sometimes write these into the review, but I wonder if it's a useful information that should actuall
by fireant 6mo ago
Do you add these into the code or into the review itself? I sometimes write these into the review, but I wonder if it's a useful information that should actually be inside the code that will get lost when the PR is merged
- therealdrag0 6mo agoInto the review is what I’m talking about. The diff is often a scattered collection of files missing context, and may have refactors that obscure behavioral changes. So there is reason to add comments that address a different readers understanding than the code rest.