5 ms·
It’s not just a wrapper for Servo, the linked poster just checked the dependencies in the Cargo file and proclaimed that without checking anything further. In
by M4v3R 8mo ago
It’s not just a wrapper for Servo, the linked poster just checked the dependencies in the Cargo file and proclaimed that without checking anything further.
In reality this project does indeed implement a functioning custom JS Engine, Layout engine, painting etc. It does borrow the CSS selectors package from Servo but that’s about it.
- oefrha 8mo agoYeah there's more to a browser than a couple of out-of-tree servo components, otherwise https://github.com/servo/servo https://github.com/servo/servo wouldn't have 300k+ lines of Rust code, 400k+ if you count comments and blanks (I cloned the repo, nuked the tests directory, then did a count). Plus that linked comment doesn't even say it's "nothing more than a non-functional wrapper for Servo". It disputes the "from scratch" claim. Most people aren't interested in a nuanced take though. Someone said something plausible sounding and was voted to top by other people? Good enough for me, have another vote. Then twist and exaggerate a little and post it to another comment section. Get more votes. Rinse and repeat.
- pera 8mo ago"Borrow" is an interesting choice of word, see for example this: /// The quirks mode of the document. #[inline] pub fn quirks_mode(&self) -> QuirksMode { self.quirks_mode } https://github.com/wilsonzlin/fastrender/blob/3e5bc78b075645fc04635336fbde6e005a6f1b5f/vendor/selectors/context.rs#L328 https://github.com/wilsonzlin/fastrender/blob/3e5bc78b075645... And then this: /// The quirks mode of the document. pub fn quirks_mode(&self) -> QuirksMode { self.stylist.quirks_mode() } https://github.com/servo/stylo/blob/71737ad5c8b29c143a6c992af6222833f5d38b43/style/context.rs#L170 https://github.com/servo/stylo/blob/71737ad5c8b29c143a6c992a... It seems ChatGPT is still copying segments of code almost verbatim, although sometimes it does weird things, compare these for example: https://github.com/wilsonzlin/fastrender/blob/3e5bc78b075645fc04635336fbde6e005a6f1b5f/vendor/selectors/parser.rs#L68 https://github.com/wilsonzlin/fastrender/blob/3e5bc78b075645... https://github.com/servo/stylo/blob/71737ad5c8b29c143a6c992af6222833f5d38b43/style/gecko/pseudo_element.rs#L356 https://github.com/servo/stylo/blob/71737ad5c8b29c143a6c992a...
- torginus 8mo agoInteresting, I remembered that when trying out Stable Diffusion, once I ventured outside of the realm of anime waifus, the images ended up being so similar to existing sources, that image search could find the references. Which is also kinda crazy since superficially there was very little similar between the 2 images, but I guess AI models used for image search converge on similar embedding than the ones used for AI generation.
- Snuggly73 8mo agoWell, could it be because it was instructed to kinda "study" Servo? https://github.com/wilsonzlin/fastrender/blob/3e5bc78b075645fc04635336fbde6e005a6f1b5f/docs/research/servo-layout-architecture.md#L4 https://github.com/wilsonzlin/fastrender/blob/3e5bc78b075645...
- nindalf 8mo agoIn your hurry to defend this slop you didn't do your due diligence. You know that 1 million LoC JS VM? Yeah, it isn't actually running - https://imgur.com/fqGLjSA https://imgur.com/fqGLjSA. And you can tell this is actually the case because it's been brought up a few times on this thread and that guy has ducked around it.