8 ms·
General rule... you have zero obligation to merge any code to your repo, much less bad code, or very large hard-to-review submissions. I think that it's bad ma
by dtnewman 9mo ago
General rule... you have zero obligation to merge any code to your repo, much less bad code, or very large hard-to-review submissions.
I think that it's bad manners for someone to submit a big PR without prior experience with the project. Someone needs to earn trust over time. They might start out with a few small PRs and gradually build up to the point where you might trust them with a larger change. But even so, a 4k-line PR is very unreasonable.
- sneas 9mo agoVibecoding tools have attracted many non-technical people who are unfamiliar with PR etiquette. There will likely be way more PRs like the one I described in the future.