5 ms·
I expected an extremely negative interpretation. My criticism is harsh because the failure here was unacceptable. Look at the pull request they merged in. Any
by adgar2 14y ago
I expected an extremely negative interpretation. My criticism is harsh because the failure here was unacceptable.
Look at the pull request they merged in. Any line added to a script which starts with "rm -rf $VARIABLE" cannot be scrutinized enough.
The first commit was created at: 2012-09-30T10:25:44-07:00.
The pull request was accepted at: 2012-09-30T10:59:08-07:00.
34 minutes to accept on a Sunday morning. I suspect that wasn't 34 minutes of review. I suspect it was closer to 34 seconds of review.
Unacceptable.
- tjholowaychuk 14y agoshit happens, and then you die. when you have 50+ people that just "+1" an issue for long enough without helping, you tend to limbo-merge
- wtallis 14y agoIf virus scanners were common on unices, their primary purpose would be to watch for the string "rm -rf".