9 ms·
Some unsolicited feedback: I think the appRoute macro obfuscates the types and signatures, and introduces some unnecessary indirection. I would get rid of it.
by faichai 11mo ago
Some unsolicited feedback:
I think the appRoute macro obfuscates the types and signatures, and introduces some unnecessary indirection. I would get rid of it.
Related, the AppContext type could be renamed RequestContext or ControllerContext or something as its App + HTTP Request + DB and not just the App.
Otherwise, I agree with other commenters that this is some of the cleanest C code I’ve seen in a while! Great effort!
- ashtonjamesd 11mo agoThank you for the feedback! I agree it does obfuscate the signature, possibly too much. I think it's okay as long as the user has the option to do both, with this made clear in the docs. Also, yes I agree, RequestContext makes more sense!