11 ms·
I am very much in the same position right now. My dev team has introduced mandatory code reviews for every change and I can see their output plummeting. It also
by Feeble 1y ago
I am very much in the same position right now. My dev team has introduced mandatory code reviews for every change and I can see their output plummeting. It also seems that most code reviews done are mostly syntax and code format related - noone actually seems to run the code or look at the actual logic if it makes sense.
I think its easy to add processes under the good intention of "making the code more robust and clean", but I never heard anyone discuss what is the cost of this process to the team's efficiency.
- mgaunard 1y agoYou need to validate things like syntax upfront so that such things don't make it to review to begin with. I'm not a fan of automatic syntax formatting but you can have some degree of pre-commit checks.
- alkonaut 1y agoThe value of having more people actually see the code will be there even if it’s just an unnecessary syntax nitpick.