7 ms·

This looks interesting, but it is quite buggy. A few things I've found: - error handling is not good. It just dumps the error JSON in the console, and doesn't

This looks interesting, but it is quite buggy. A few things I've found: - error handling is not good. It just dumps the error JSON in the console, and doesn't read and understand it, so keeps retrying even if it's something that it clearly needs to change - ESC is pretty unreliable at interrupting ongoing activity - I'd expect to be able to use arrow keys to navigate through history - is there a way to change the preference order for models? It succeeded in my standard task of adding support for detecting itself to am-i-vibing, but it got stuck in some API errors before it was able to create a PR. It does now have support though after a little help: https://github.com/ascorbic/am-i-vibing https://github.com/ascorbic/am-i-vibing

reissbaker 1y ago
Ah, I actually find it useful to see the error output! But I can add a flag to hide it. Yes, you can change the ordering by going to the menu (via ESC), and going to "Settings" and then "Set default model." (You can also just edit the model order in the config file at ~/.config/octofriend/octofriend.json5). ESC should reliably interrupt the model, although it doesn't currently interrupt tool calls — I'll add that (although all tool calls have timeouts currently).
- ascorbic 1y ago
  It's useful, but by default it would be best to just show the error message, not a screen full of JSON from the Vercel SDK
  - reissbaker 1y ago
    This is very good feedback thank you :D I'll ship these improvements tonight.
    - reissbaker 1y ago
      FYI, I just shipped a new version that addresses: 1. Verbose errors are hidden by default. You can run octofriend with OCTO_VERBOSE=1 set in your shell's env vars to see the verbose errors. 2. Pretty much everything can be interrupted via ESC now, not just model responses. Bash commands will be killed (first via SIGINT, then via SIGTERM if they don't respond quickly), the web fetch tool will kill requests, etc. Thanks for all the feedback :)
esafak 1y ago
After reading this comment I checked the repo's tests. There were few.

reissbaker 1y ago

Ah, I actually find it useful to see the error output! But I can add a flag to hide it. Yes, you can change the ordering by going to the menu (via ESC), and going to "Settings" and then "Set default model." (You can also just edit the model order in the config file at ~/.config/octofriend/octofriend.json5). ESC should reliably interrupt the model, although it doesn't currently interrupt tool calls — I'll add that (although all tool calls have timeouts currently).

ascorbic 1y ago
It's useful, but by default it would be best to just show the error message, not a screen full of JSON from the Vercel SDK
- reissbaker 1y ago
  This is very good feedback thank you :D I'll ship these improvements tonight.
  - reissbaker 1y ago
    FYI, I just shipped a new version that addresses: 1. Verbose errors are hidden by default. You can run octofriend with OCTO_VERBOSE=1 set in your shell's env vars to see the verbose errors. 2. Pretty much everything can be interrupted via ESC now, not just model responses. Bash commands will be killed (first via SIGINT, then via SIGTERM if they don't respond quickly), the web fetch tool will kill requests, etc. Thanks for all the feedback :)

esafak 1y ago

After reading this comment I checked the repo's tests. There were few.