5 ms·
Read this as though it has a visibly bulging temple vein: Does that mean you do the thing where I respond to your review, request a re-review, then get comment
by devnullbrain 1y ago
Read this as though it has a visibly bulging temple vein:
Does that mean you do the thing where I respond to your review, request a re-review, then get comments about code that was already there a week ago?!
- lmm 1y agoIf your PR had lots of stuff that needs comments then I don't think you can reasonably expect me to check it fully in the first pass. E.g. if your first 3 functions are indented wrong, I'm going to write that they're indented wrong and not bother reading the rest of your PR until you've fixed that.
- Our_Benefactors 1y ago> E.g. if your first 3 functions are indented wrong, I'm going to write that they're indented wrong and not bother reading the rest of your PR until you've fixed that. Just add a linter and precommit hook, it’s not a good use of anyone’s time to go back and forth over trivialities.
- lmm 1y agoI know, just using it as a clear example. Point is if your PR has a lot of low-level issues then I'm not going to start on the higher level review until you've fixed them.