6 ms·
I've recently started using Github code reviews for a lot of C++, and one thing that I wish it would do is show the header (.h) files before the implementation
by slongfield 1y ago
I've recently started using Github code reviews for a lot of C++, and one thing that I wish it would do is show the header (.h) files before the implementation (.cc) files.
Small PRs help, but I often end up just opening a handful of windows to have everything open at once.
- rwmj 1y agoYou can't do that in github as far as I know, but you can get git to display diffs that way (eg. for local review or email based workflows). You have to use a git "orderfile". Example: https://gitlab.com/nbdkit/nbdkit/-/blob/master/scripts/git.orderfile?ref_type=heads https://gitlab.com/nbdkit/nbdkit/-/blob/master/scripts/git.o... We found it useful to display header files, interface files and documentation first, but maybe the linked paper will make us review that!
- devnullbrain 1y agoGithub similarly lacks the ability to override the diff algorithm. This is a shame, because `histogram` makes some diffs look much more like what the human intended. The default, Myers, is from 1986!
- devnullbrain 1y agoFor this reason I usually either check it out locally or use the Github IDE (. or >)