21 ms·
Good point. I guess it also depends on what are you further looking into. A few months ago I implemented a feature a client requested that was being charged by
by DanielVZ 2y ago
Good point. I guess it also depends on what are you further looking into. A few months ago I implemented a feature a client requested that was being charged by the hour. When code review came a more senior engineer suggested a huge refactor that in the end would leave cleaner code but required changing half of the small code base. I pushed back saying it wasn’t necessary due to the scale of the library we were working on. Turns out he took on the task to refactor it himself, broke both my code and preexisting code, and I had to go in and spend triple the amount of time debugging the refactor. A few months pass by and the whole code base will forcefully have to be refactored again to be merged into another code base.
He was looking further into making a clean code base, but I was looking further into saving our clients a few thousand bucks and delivering early. Which one was right? I’ll reflect on that after this new refactor and see how much the previous one helps (or doesn’t).