15 ms·

Totally random, but I had a guess about the ts error. I hadn't seen kysely before, very cool! diff --git a/packages/lix-sdk/src/query-utilities/is-in-simula

Totally random, but I had a guess about the ts error. I hadn't seen kysely before, very cool! diff --git a/packages/lix-sdk/src/query-utilities/is-in-simulated-branch.ts b/packages/lix-sdk/src/query-utilities/is-in-simulated-branch.ts index 7d677477e..39502f245 100644 --- a/packages/lix-sdk/src/query-utilities/is-in-simulated-branch.ts +++ b/packages/lix-sdk/src/query-utilities/is-in-simulated-branch.ts @@ -21,10 +21,9 @@ export function isInSimulatedCurrentBranch( // change is not in a conflict eb("change.id", "not in", (subquery) => subquery.selectFrom("conflict").select("conflict.change_id").unionAll( - // @ts-expect-error - no idea why subquery .selectFrom("conflict") - .select("conflict.conflicting_change_id"), + .select("conflict.conflicting_change_id as change_id"), ), ), // change is in a conflict that has not been resolved

samuelstros 2y ago
You are now forever in our git history https://github.com/opral/monorepo/commit/58734e11e51d8e20092 https://github.com/opral/monorepo/commit/58734e11e51d8e20092.... the ts-expect-error was indeed fixed by your suggestion
- ec109685 2y ago
  Isn’t kind just overriding the type checker? Should that as be necessary?
  - samuelstros 2y ago
    Yes. The runtime was not affected. Hence, the ts-expect-error. Still nice to have the ts-expect-error fixed :)
  - surrealize 2y ago
    In the context of the union query, I think it makes sense. The query takes two different columns (with two different names) from the same table, and combines them together into one column. The TS error happened because the column names didn't match between the two union inputs. But they would never match without the "as".
- surrealize 2y ago
  Cool! I'm surrealize though, sureglymop wrote a sibling comment! I should have just made a PR, lol.
- samuelstros 2y ago
  Today i learned that HN has a nesting limit. @surrealize i fixed the username https://github.com/opral/monorepo/commit/7dc1f3c806bd89c6d682a2006e487cb4501ef655 https://github.com/opral/monorepo/commit/7dc1f3c806bd89c6d68...
  - surrealize 2y ago
    Haha, thanks!
  - aspenmayer 2y ago
    The conversation in some aspect may have tripped the flamewar detection, which removes the reply button iirc. You can manually reply to a specific comment by clicking/tapping on on its timestamp.

samuelstros 2y ago

You are now forever in our git history https://github.com/opral/monorepo/commit/58734e11e51d8e20092 https://github.com/opral/monorepo/commit/58734e11e51d8e20092.... the ts-expect-error was indeed fixed by your suggestion

ec109685 2y ago
Isn’t kind just overriding the type checker? Should that as be necessary?
- samuelstros 2y ago
  Yes. The runtime was not affected. Hence, the ts-expect-error. Still nice to have the ts-expect-error fixed :)
- surrealize 2y ago
  In the context of the union query, I think it makes sense. The query takes two different columns (with two different names) from the same table, and combines them together into one column. The TS error happened because the column names didn't match between the two union inputs. But they would never match without the "as".
surrealize 2y ago
Cool! I'm surrealize though, sureglymop wrote a sibling comment! I should have just made a PR, lol.
samuelstros 2y ago
Today i learned that HN has a nesting limit. @surrealize i fixed the username https://github.com/opral/monorepo/commit/7dc1f3c806bd89c6d682a2006e487cb4501ef655 https://github.com/opral/monorepo/commit/7dc1f3c806bd89c6d68...
- surrealize 2y ago
  Haha, thanks!
- aspenmayer 2y ago
  The conversation in some aspect may have tripped the flamewar detection, which removes the reply button iirc. You can manually reply to a specific comment by clicking/tapping on on its timestamp.