7 ms·

Looks like it? 4 years old commits

by perrohunter 2y ago

api 2y ago
Why is that a bad thing? Maybe it just works and doesn't need further changes.
- Aerbil313 2y ago
  Cause it presumably has to be compatible with Wireguard upstream?
  - api 2y ago
    Wireguard is a pretty fixed and simple standard. Nothing needs to happen.
    - throwaway290232 2y ago
      [dead]
    - freeopinion 2y ago
      So the "tcp: fix incorrect undo caused by DSACK of TLP retransmit" done five weeks ago for the Linux kernel didn't need to happen for the Rust implementation?
      - palunon 2y ago
        I don't think this commit has anything to do with wireguard. It's a fix of a bug in the kernel TCP stack, which wireguard doesn't use. (Beware, the wireguard-linux repo is a "fork" of the complete linux kernel) And even if it did, a userland TUN implementation of the wireguard protocol probably doesn't have the same bugs as the linux kernel one.
    - verandaguy 2y ago
      Sure, the standard is relatively straightforward, but the implementations have to keep up with their environment. Wireguard in Linux has to keep up with changes in the kernel to a degree, for example.
- palunon 2y ago
  Looking at the supported platforms, it looks like the only one is Linux. The README has this to say about it though: "This will run on Linux; however YOU SHOULD NOT RUN THIS ON LINUX. Instead use the kernel module; see the installation page for instructions."
  - GoblinSlayer 2y ago
    It's like git: you write it for linux, then leave it as is.
- mhio 2y ago
  How do rust projects work over rust versions? Is rust stable enough from 20-24 that the project would likely remain in a state to compile on a new rust tool chain? Do "Editions" completely solve this?
  - mmastrac 2y ago
    Pretty much. I've had a great deal of luck rebuilding older projects. You can lock your toolchain as an added protection, but `cargo clippy --fix` is often enough to fix 90% of those. I think the only time I really struggled with a toolchain upgrade was with one of the crypto libraries that was bringing in a broken version of some SIMD code (cannot remember the exact details). For kicks I cloned and build this with Rust 1.80 and it built just fine (a few reasonable warnings), and even bumped the edition up to 2021. The README suggests you need nightly but that's clearly not the case. EDIT: the Rust code is actually unsoundly using MaybeUnit in a few places.
    - mhio 2y ago
      Thanks for the info. Is "lock your toolchain" via rustup? It appears to be the equivalent of rbenv/pyenv/nodenv/asdf etc but part of rust.
  - deleted 2y ago
    [deleted]

Looks like it? 4 years old commits

api 2y ago

Why is that a bad thing? Maybe it just works and doesn't need further changes.

Aerbil313 2y ago
Cause it presumably has to be compatible with Wireguard upstream?
- api 2y ago
  Wireguard is a pretty fixed and simple standard. Nothing needs to happen.
  - throwaway290232 2y ago
    [dead]
  - freeopinion 2y ago
    So the "tcp: fix incorrect undo caused by DSACK of TLP retransmit" done five weeks ago for the Linux kernel didn't need to happen for the Rust implementation?
    - palunon 2y ago
      I don't think this commit has anything to do with wireguard. It's a fix of a bug in the kernel TCP stack, which wireguard doesn't use. (Beware, the wireguard-linux repo is a "fork" of the complete linux kernel) And even if it did, a userland TUN implementation of the wireguard protocol probably doesn't have the same bugs as the linux kernel one.
  - verandaguy 2y ago
    Sure, the standard is relatively straightforward, but the implementations have to keep up with their environment. Wireguard in Linux has to keep up with changes in the kernel to a degree, for example.
palunon 2y ago
Looking at the supported platforms, it looks like the only one is Linux. The README has this to say about it though: "This will run on Linux; however YOU SHOULD NOT RUN THIS ON LINUX. Instead use the kernel module; see the installation page for instructions."
- GoblinSlayer 2y ago
  It's like git: you write it for linux, then leave it as is.
mhio 2y ago
How do rust projects work over rust versions? Is rust stable enough from 20-24 that the project would likely remain in a state to compile on a new rust tool chain? Do "Editions" completely solve this?
- mmastrac 2y ago
  Pretty much. I've had a great deal of luck rebuilding older projects. You can lock your toolchain as an added protection, but `cargo clippy --fix` is often enough to fix 90% of those. I think the only time I really struggled with a toolchain upgrade was with one of the crypto libraries that was bringing in a broken version of some SIMD code (cannot remember the exact details). For kicks I cloned and build this with Rust 1.80 and it built just fine (a few reasonable warnings), and even bumped the edition up to 2021. The README suggests you need nightly but that's clearly not the case. EDIT: the Rust code is actually unsoundly using MaybeUnit in a few places.
  - mhio 2y ago
    Thanks for the info. Is "lock your toolchain" via rustup? It appears to be the equivalent of rbenv/pyenv/nodenv/asdf etc but part of rust.
- deleted 2y ago
  [deleted]