8 ms·
Good catch. The team could add this rule to their Ellipsis config file to make sure that it's always flagged: "Never use magic numbers. Always store the number
by hunterbrooks 2y ago
Good catch. The team could add this rule to their Ellipsis config file to make sure that it's always flagged: "Never use magic numbers. Always store the number in a variable and use the variable instead."
Docs: https://docs.ellipsis.dev/config#add-custom-rules https://docs.ellipsis.dev/config#add-custom-rules
- azinman2 2y agoBut even that isn’t ALWAYS the case. There are times when it is appropriate to have numbers inline, as long as they’re not repeated. This is where good judgement comes in, which is difficult to encode rules for.