6 ms·
I don’t use pre-commit checks but I use linters before every PR and checks will fail and not allow a merge if they aren’t applied. I prefer flake8, black, and i
by interbased 2y ago
I don’t use pre-commit checks but I use linters before every PR and checks will fail and not allow a merge if they aren’t applied. I prefer flake8, black, and isort at the moment. Though, black and flake8 can conflict, but you can adjust the settings in flake8.
- Gooblebrai 2y agoSo you need to remember doing the linting and formatting or the PR will fail? I'd argue that's the point of pre-commit. Doing it for you locally before submitting the PR so you don't have to be mindful about it.
- foobarbaz33 2y agoMight depend on your workflow. Let's say you are in a private feature branch. You do many commits, 1 per minute to create save points as you work on some mind bending logic. You need those saves to go through no matter what, even when things are broken. You plan to squash all the feature commits when you are done so you don't care about the formatting quite as strongly for commits that will disappear soon anyway.