6 ms·

Funnily enough, GitLab is also melting down at the moment, with pipelines not running and pull requests not functioning: https://status.gitlab.com/ https://sta

Funnily enough, GitLab is also melting down at the moment, with pipelines not running and pull requests not functioning: https://status.gitlab.com/ https://status.gitlab.com/

kingds 3y ago
what's a pull request?
- tmpz22 3y ago
  A pull request is a process which can merge new code into existing code. "Software Engineer John was tasked to add a new logo to the website, when he was done he submitted a pull request of his feature branch into his organization's github repository for the website so that his team members could approve the changes before automation (like Github Actions) deployed live as a new version of the website."
  - nightfly 3y ago
    Gitlab has "merge requests" the comment you're replying was trying to point out an error in an annoying way
    - kingds 3y ago
      i tried to add a lil laughing emoji to indicate that my comment was in jest but apparently those get stripped out of comments? my bad.
      - c-hendricks 3y ago
        Yeah HN doesn't want people to be _too_ expressive.
      - midasuni 3y ago
        :D doesn’t get stripped
    - OJFord 3y ago
      Not even an error frankly, MR, PR, change request, patch set, personally don't care what you call it, it's the same thing.
- momentoftop 3y ago
  It's a request to the owner of some reference in a Git repository to pull in some changes from some reference in some (possibly other) Git repository. You can do this via email, but centralised Git hosts like Github have their own interface to this basic workflow.
- smcleod 3y ago
  I agree the naming is misleading - it's not actually a request to pull anything - it's a request to merge someone's branch into another. This is known as a merge request on several other platforms.
bencevans 3y ago
Also causing issues due to a change that's made release source tars change [1] (changing hash), so build systems are rejecting [2]. 1: https://gitlab.com/gitlab-org/gitlab/-/issues/402616 https://gitlab.com/gitlab-org/gitlab/-/issues/402616 2: https://github.com/microsoft/vcpkg/issues/30481 https://github.com/microsoft/vcpkg/issues/30481
- mardifoufs 3y ago
  Isn't that the same "bug" that happened to github a few weeks ago when they updated their Git version too? It wasn't a bug per say but they still had to revert because the new hashes were causing massive build problems. Maybe it's a different root cause though.
- Rapzid 3y ago
  Holy cow. The cardinal DevOps sin of changing the contents of a versioned file.
midasuni 3y ago
My on prem git lab has been fine with it’s pipelines, and given it’s impossible to have an on prem uptime higher than the cloud what you say can’t be true.

Funnily enough, GitLab is also melting down at the moment, with pipelines not running and pull requests not functioning: https://status.gitlab.com/ https://status.gitlab.com/

kingds 3y ago

what's a pull request?

tmpz22 3y ago
A pull request is a process which can merge new code into existing code. "Software Engineer John was tasked to add a new logo to the website, when he was done he submitted a pull request of his feature branch into his organization's github repository for the website so that his team members could approve the changes before automation (like Github Actions) deployed live as a new version of the website."
- nightfly 3y ago
  Gitlab has "merge requests" the comment you're replying was trying to point out an error in an annoying way
  - kingds 3y ago
    i tried to add a lil laughing emoji to indicate that my comment was in jest but apparently those get stripped out of comments? my bad.
    - c-hendricks 3y ago
      Yeah HN doesn't want people to be _too_ expressive.
    - midasuni 3y ago
      :D doesn’t get stripped
  - OJFord 3y ago
    Not even an error frankly, MR, PR, change request, patch set, personally don't care what you call it, it's the same thing.
momentoftop 3y ago
It's a request to the owner of some reference in a Git repository to pull in some changes from some reference in some (possibly other) Git repository. You can do this via email, but centralised Git hosts like Github have their own interface to this basic workflow.
smcleod 3y ago
I agree the naming is misleading - it's not actually a request to pull anything - it's a request to merge someone's branch into another. This is known as a merge request on several other platforms.

bencevans 3y ago

Also causing issues due to a change that's made release source tars change [1] (changing hash), so build systems are rejecting [2]. 1: https://gitlab.com/gitlab-org/gitlab/-/issues/402616 https://gitlab.com/gitlab-org/gitlab/-/issues/402616 2: https://github.com/microsoft/vcpkg/issues/30481 https://github.com/microsoft/vcpkg/issues/30481

mardifoufs 3y ago
Isn't that the same "bug" that happened to github a few weeks ago when they updated their Git version too? It wasn't a bug per say but they still had to revert because the new hashes were causing massive build problems. Maybe it's a different root cause though.
Rapzid 3y ago
Holy cow. The cardinal DevOps sin of changing the contents of a versioned file.

midasuni 3y ago

My on prem git lab has been fine with it’s pipelines, and given it’s impossible to have an on prem uptime higher than the cloud what you say can’t be true.