5 ms·

Unfortunately the author of this PR decided to include garbage like this [1] in it, so this PR is pretty useless. [1] https://github.com/basujindal/stable-diff

Unfortunately the author of this PR decided to include garbage like this [1] in it, so this PR is pretty useless. [1] https://github.com/basujindal/stable-diffusion/pull/103/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7 https://github.com/basujindal/stable-diffusion/pull/103/file...

deleted 4y ago
[deleted]
kevingadd 4y ago
You're still able to run it locally even if the license change prevents it from being merged, and it seems to be a proof of concept that may inspire other people to optimize it in different ways
jinseokim 4y ago
I just reminded "clean room design" technique: https://en.m.wikipedia.org/wiki/Clean_room_design https://en.m.wikipedia.org/wiki/Clean_room_design
- javchz 4y ago
  Yeah, reminds me of the old freedoom WADs situation
Matheus28 4y ago
Seems like author did his work on a different fork and pushed to this one, which included all changes from the other fork...
cercatrova 4y ago
How is that garbage? That license is part of the original SD repository, the creator Emad even talks about it in his initial post, about the OpenRAIL M License [0]: > i) The model is being released under a Creative ML OpenRAIL-M license [https://huggingface.co/spaces/CompVis/stable-diffusion-license https://huggingface.co/spaces/CompVis/stable-diffusion-licen...]. This is a permissive license that allows for commercial and non-commercial usage. This license is focused on ethical and legal use of the model as your responsibility and must accompany any distribution of the model. It must also be made available to end users of the model in any service on it. [0] https://stability.ai/blog/stable-diffusion-public-release https://stability.ai/blog/stable-diffusion-public-release
- deleted 4y ago
  [deleted]
- zarzavat 4y ago
  It’s worth to point out that there’s no consensus yet on whether ML models (as in the weights) are actually copyrightable. If you’re using them, you should probably assume that they are. If you’re distributing them, you should probably assume that they aren’t.
- whywhywhywhy 4y ago
  they mean the entire thing has been run through some sort of "beautifier" so there are thousands of irrelevant whitespace changes across things unrelated to the commit, which itself is around 6 lines.
sercand 4y ago
This is the worst type of PR. Just submit a different PR for the code format changes.

deleted 4y ago

[deleted]

kevingadd 4y ago

You're still able to run it locally even if the license change prevents it from being merged, and it seems to be a proof of concept that may inspire other people to optimize it in different ways

jinseokim 4y ago

I just reminded "clean room design" technique: https://en.m.wikipedia.org/wiki/Clean_room_design https://en.m.wikipedia.org/wiki/Clean_room_design

javchz 4y ago
Yeah, reminds me of the old freedoom WADs situation

Matheus28 4y ago

Seems like author did his work on a different fork and pushed to this one, which included all changes from the other fork...

cercatrova 4y ago

How is that garbage? That license is part of the original SD repository, the creator Emad even talks about it in his initial post, about the OpenRAIL M License [0]: > i) The model is being released under a Creative ML OpenRAIL-M license [https://huggingface.co/spaces/CompVis/stable-diffusion-license https://huggingface.co/spaces/CompVis/stable-diffusion-licen...]. This is a permissive license that allows for commercial and non-commercial usage. This license is focused on ethical and legal use of the model as your responsibility and must accompany any distribution of the model. It must also be made available to end users of the model in any service on it. [0] https://stability.ai/blog/stable-diffusion-public-release https://stability.ai/blog/stable-diffusion-public-release

deleted 4y ago
[deleted]
zarzavat 4y ago
It’s worth to point out that there’s no consensus yet on whether ML models (as in the weights) are actually copyrightable. If you’re using them, you should probably assume that they are. If you’re distributing them, you should probably assume that they aren’t.
whywhywhywhy 4y ago
they mean the entire thing has been run through some sort of "beautifier" so there are thousands of irrelevant whitespace changes across things unrelated to the commit, which itself is around 6 lines.

sercand 4y ago

This is the worst type of PR. Just submit a different PR for the code format changes.