5 ms·

We discovered a 7-year old performance issue in Elixir (2020)

85 points by s3cur3 4y ago

pmontra 4y ago
Redirected to gdpr.tubitv.com > Tubi is the largest free movie and TV streaming service in the US. Unfortunately, we're not currently available in your area. So I can't even know how it works. Wikipedia to the rescue https://en.wikipedia.org/wiki/Tubi https://en.wikipedia.org/wiki/Tubi It seems to be ad supported.
- ReactiveJelly 4y ago
  If you turn off JS, this archive.org link kinda works https://web.archive.org/web/20201226070313/https://code.tubitv.com/how-we-discovered-a-7-year-old-performance-issue-in-elixir-99080bdce9a1?gi=69a287a21bba https://web.archive.org/web/20201226070313/https://code.tubi... But I think the images are loaded via JS, so you only get text. There is some strange redirect loop (302, 307, 302, 307...) if you leave JS on. Probably some bug in Medium's JS, and it confused the archiver?
randomhodler84 4y ago
2020 post. Good write up on technical issue that demonstrated tooling and process to identify a superfluous regex compile in the base framework. Quick patch and suddenly it’s faster for everyone! Neat!
Kabie 4y ago
Interestingly enough, I find myself rarely using regex with Elixir. Thanks to erlang's excellent pattern matching syntax for binary.
- throwawaymaths 4y ago
  I either use pattern matching for easy things or reach for nimble parsec.
- AtNightWeCode 4y ago
  Regex should be kept to a minimum in an API because it is a known DOS attack vector. Sounds a bit worrying if they also have parameters that affect execution time.
d3nj4l 4y ago
Love the fact that they got the PR through in 10 minutes. Jose Valim is genuinely one of the warmest and most welcoming language BDFLs I've ever seen, and I don't believe Elixir would be as great without him.
- prophesi 4y ago
  He's helped me several times in the #elixir freenode channel as well. And of course their elixir books are a godsend.
  - mercer 4y ago
    Same here. More than once I asked a question on the channel (now on Libera?) and the first person to answer would be Jose. I can highly recommend the series of interviews that the Thinking Elixir podcast did with him where they go through the entire history of Elixir versions: https://podcast.thinkingelixir.com/ https://podcast.thinkingelixir.com/
  - albatross13 4y ago
    As someone who loves Elixir, but is bad at it, which books are you referring to? I will buy them instantly.
    - sph 4y ago
      Elixir in Action is pretty good
      - albatross13 4y ago
        Much appreciated!
- sph 4y ago
  He's everywhere. You open a issue on one of the dozen most used Elixir libraries, and he'll answer by end of day. I envy his work ethic and I appreciate how he's always very patient with everybody. In general everyone at dashbit seem to be very warm people. Good culture fosters good culture.

85 points by s3cur3 4y ago

Redirected to gdpr.tubitv.com > Tubi is the largest free movie and TV streaming service in the US. Unfortunately, we're not currently available in your area. So I can't even know how it works. Wikipedia to the rescue https://en.wikipedia.org/wiki/Tubi https://en.wikipedia.org/wiki/Tubi It seems to be ad supported.

ReactiveJelly 4y ago
If you turn off JS, this archive.org link kinda works https://web.archive.org/web/20201226070313/https://code.tubitv.com/how-we-discovered-a-7-year-old-performance-issue-in-elixir-99080bdce9a1?gi=69a287a21bba https://web.archive.org/web/20201226070313/https://code.tubi... But I think the images are loaded via JS, so you only get text. There is some strange redirect loop (302, 307, 302, 307...) if you leave JS on. Probably some bug in Medium's JS, and it confused the archiver?

randomhodler84 4y ago

2020 post. Good write up on technical issue that demonstrated tooling and process to identify a superfluous regex compile in the base framework. Quick patch and suddenly it’s faster for everyone! Neat!

Kabie 4y ago

Interestingly enough, I find myself rarely using regex with Elixir. Thanks to erlang's excellent pattern matching syntax for binary.

throwawaymaths 4y ago
I either use pattern matching for easy things or reach for nimble parsec.
AtNightWeCode 4y ago
Regex should be kept to a minimum in an API because it is a known DOS attack vector. Sounds a bit worrying if they also have parameters that affect execution time.

d3nj4l 4y ago

Love the fact that they got the PR through in 10 minutes. Jose Valim is genuinely one of the warmest and most welcoming language BDFLs I've ever seen, and I don't believe Elixir would be as great without him.

prophesi 4y ago
He's helped me several times in the #elixir freenode channel as well. And of course their elixir books are a godsend.
- mercer 4y ago
  Same here. More than once I asked a question on the channel (now on Libera?) and the first person to answer would be Jose. I can highly recommend the series of interviews that the Thinking Elixir podcast did with him where they go through the entire history of Elixir versions: https://podcast.thinkingelixir.com/ https://podcast.thinkingelixir.com/
- albatross13 4y ago
  As someone who loves Elixir, but is bad at it, which books are you referring to? I will buy them instantly.
  - sph 4y ago
    Elixir in Action is pretty good
    - albatross13 4y ago
      Much appreciated!
sph 4y ago
He's everywhere. You open a issue on one of the dozen most used Elixir libraries, and he'll answer by end of day. I envy his work ethic and I appreciate how he's always very patient with everybody. In general everyone at dashbit seem to be very warm people. Good culture fosters good culture.