6 ms·
I really enjoy code reviewing, and maybe I'm weird but I especially enjoy CR'ing huge PR's. It's like a puzzle to figure out what's going on and write advice in
by codeptualize 5y ago
I really enjoy code reviewing, and maybe I'm weird but I especially enjoy CR'ing huge PR's. It's like a puzzle to figure out what's going on and write advice in a way that is clear, constructive, helpful, and appreciated. And when it's a really good PR it's even more fun, seeing people make great progress and do great work is truly enjoyable.
It can also be challenging though, especially preventing it turning negative if there is need for big changes. Also making judgement calls of what matters and what is nitpicking. Imo it's essential to stay on the conservative side as nitpicking is a giant waste of time and incredibly demotivating.
You mention reining in, which doesn't sound fun. What you might try is to find ways to not say "no" but actually demonstrate or teach why you might or might not want to do something, or just focus on the alternative. Basically challenge yourself to find ways you can give people the opportunity to learn the lesson themselves in an engaging motivating way, instead of having to hold them back. Also maybe let some things go, not everything will cause disasters.
Few more things I find work well;
- Outside of normal work learning activities; workshops, presentations etc. (let them present as well)
- Solicit feedback yourself; Create an environment where it's normal and appreciated.
- Give "optional" advice, give them the choice to follow it or not.
To come back to your question; I find it really challenging at times, but definitely not boring. I think seeing it as a challenge might generally help to find the joy in it.
- brokencode 5y agoGood advice! I think it would make it more interesting to challenge myself to help junior developers grow as much as possible. I guess sometimes I feel like people will grow on their own, and that my mentoring doesn’t really make a difference. But maybe I’m misjudging how much I could help if I really applied myself to it. And to be clear, I think using “rein in” was bad wording on my part, due to the negative connotations, and I regret not writing that differently. I do give advice and try to teach rather than to just say no or criticizing, and I’ve gotten a lot of positive feedback for how I work with junior developers. It just hasn’t been something really fulfilling to me.
- codeptualize 5y agoSure! I got that from your post, and I also recognize it btw; it can feel like you have to "rein in", which is not very enjoyable. But yes, you can have major impact on individual people and on the team as a whole, and if you got positive feedback in the past you are probably already doing that. Instead of designing code/product, you are designing an environment and culture where people can feel good, improve themselves, and do their best work. Really challenging, but really fulfilling if it goes well. Good luck! I hope you can find the joy in it.
- mdaniel 5y ago> I really enjoy code reviewing, and maybe I'm weird but I especially enjoy CR'ing huge PR's I don't have any affiliation beyond that I applied, seemingly unsuccessfully, but this may interest you: https://app.pullrequest.com/signups/reviewer https://app.pullrequest.com/signups/reviewer
- codeptualize 5y agoThanks for the link! I was not aware this was a thing, it looks very interesting.