4 ms·
Standard advice is to wait two full weeks, then bump your thread (or rebase the patch and send a v2 if there's new conflicts with the maintainer's tree).
by tych0 5y ago
Standard advice is to wait two full weeks, then bump your thread (or rebase the patch and send a v2 if there's new conflicts with the maintainer's tree).
- charcircuit 5y agoIt sounded like he just filed a bug.
- jakeinspace 5y agoIt’s a 1-line patch, I didn’t send it in my initial email but maybe that was a faux pas.
- tych0 5y agoI'd say sending the patch with git send-email --in-reply-to=<the header of your last email> is good. A patch is much easier to apply than write :)
- jakeinspace 5y agoThanks! Would you recommend I send to the maintainer(s), and Cc the mailing list?
- tych0 5y agoYeah, I'd just use whatever the output of ./scripts/get_maintainer.pl says. It will also suggest any recent committers to that area of the code, which I've found useful in the past. Usually I put the maintainers as To:, and everyone else as Cc:.