6 ms·
Most of the "bugs" caught here (including in TensorFlow and in my own project, Xarray) seems to actually be typos in the test suite. This is certainly a good ca
by shoyer 5y ago
Most of the "bugs" caught here (including in TensorFlow and in my own project, Xarray) seems to actually be typos in the test suite. This is certainly a good catch (and yes, linters should check for this!), but seems a little oversold to me.
- chillee 5y agoSame :P I'm actually responsible for one of these (https://github.com/pytorch/pytorch/issues/70607 https://github.com/pytorch/pytorch/issues/70607), but it's a typo in a list of tests to skip.
- hvdijk 5y agoA typo in a list of tests to skip means tests are run that are not intended to be run. This can lead to unexpected failures, so in my opinion is not the same as the errors in test suites where tests run with other test data than intended but should still pass.