4 ms·
You can also initialize the words in more pythonic way: with open('/usr/share/dict/words') as wordlist: words = set(line[:-1] for line in wordlist) Or
by iki23 15y ago
You can also initialize the words in more pythonic way:
with open('/usr/share/dict/words') as wordlist:
words = set(line[:-1] for line in wordlist)
Or, for one time check you can stop reading on match:
import sys
lookup = '%s\n' % sys.argv[1]
with open('/usr/share/dict/words') as wordlist:
[ sys.stdout.write('Dictionary password: %s' % lookup) or sys.exit(1) for line in wordlist if line == lookup ]
As for the objective, this checks only exact dictionary matches. In real world, you'd use cracklib to check any dictionary based or weak passwords rather than reinvent the wheel. See http://gdub.wordpress.com/2006/08/26/using-cracklib-to-require-stronger-passwords/ http://gdub.wordpress.com/2006/08/26/using-cracklib-to-requi...
- vog 15y agoWhile I agree that the first code is pythonic and nice, the second code is quite the opposite of that. Why forcing imperative code into a list comprehension? It is a lot easier to read as nested loop, as it doesn't build a dummy list with some strange "or" operation: import sys lookup = '%s\n' % sys.argv[1] with open('/usr/share/dict/words') as wordlist: for line in wordlist: if line == lookup: sys.stdout.write('Dictionary password: %s' % lookup) sys.exit(1)
- nerfhammer 15y agobetter to pickle a frozenset and use that. import pickle # initialize: wordset = frozenset(line.lower().rstrip() for line in open('/usr/share/dict/words')) pickle.dump(wordset, open('/tmp/wordset.pkl', 'wb', -1)) # when you want to use it: wordset = pickle.load(open('/tmp/wordset.pkl', 'rb')) 'bear' in wordset # == True
- iki23 15y agoThanks for the frozenset. Yet pickle makes the file 2 times bigger and 20 times slower to parse on my machine: >python wordlist.py -w wordlist -p wordlist.pkl >python wordlist.py -T wordlist wordlist.pkl 10 3 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] words(wordfile): 142.50 best msec/loop words_slower(wordfile): 161.00 best msec/loop words_normalized(wordfile): 295.84 best msec/loop words_pickled(pickled): 2943.66 best msec/loop The winner is: with open(wordfile) as wordlist: return frozenset(wordlist.read().split('\n')) Source: https://gist.github.com/1059725 https://gist.github.com/1059725 Wordlist: http://www.freebsd.org/cgi/cvsweb.cgi/src/share/dict/web2?rev=1.14;content-type=text/plain http://www.freebsd.org/cgi/cvsweb.cgi/src/share/dict/web2?re... Do you have different results?
- iki23 15y agoright, the space saving harmed readability indeed, thanks