6 ms·
Can you share how many spam PRs did you have? I thought to check here https://github.com/chartjs/Chart.js/pulls https://github.com/chartjs/Chart.js/pulls on my
by derberg 6y ago
Can you share how many spam PRs did you have? I thought to check here https://github.com/chartjs/Chart.js/pulls https://github.com/chartjs/Chart.js/pulls on my own but unfortunately you did not mark those with invalid or spam labels. For such a popular project like yours, did you get many? Was it overwhelming?
I'm really curious
- etimberg 6y agoI counted a total of 9. I went back and labelled them as spam. https://github.com/chartjs/Chart.js/pulls?q=is%3Apr+is%3Aclosed+label%3Aspam https://github.com/chartjs/Chart.js/pulls?q=is%3Apr+is%3Aclo... To be honest, I was expecting a lot worse. There were a few that we allowed in that were in a grey area though. 3 or 4 small PRs fixing typos in the docs that really should have been a single PR, but since it was actually improving things I let it slide.
- derberg 6y agoAwesome, thanks for the numbers! I feel great reading what was your approach here. Thanks!