8 ms·

Yeah, but the question is how far should we go with that. Should we do : const isFalsy = require("is-falsy"); const isObject = require("is-object");

Yeah, but the question is how far should we go with that. Should we do : const isFalsy = require("is-falsy"); const isObject = require("is-object"); const isFunction = require( "is-function" ); const hasThen = require( "has-then" ); function isPromise(obj) { return !isFalsy(obj) && ( isObject(obj) || isFunction(obj) ) && hasThen( obj ); } Just because the code line is more than 50 characters, doesn't mean that we need a new library for that.

enitihas 6y ago
I think all of the above might already be libraries on npm. From what I remember, npm has isInteger, isPositive, is-odd, is-even.
- recursive 6y ago
  All of the packages you mentioned are maintained by the same guy.
  - sergiotapia 6y ago
    Have you seen his twitter? It's incredibly cringey. I don't understand how someone could be so arrogant to claim millions of companies use his software, when his software is isFalse. Not to mention his hundreds of packages that literally just output an emoji.
    - artificial 6y ago
      Reminds me of Dr. Evil’s monologue about his Father making ridiculous claims about inventing the question mark.
dragonwriter 6y ago
isFalsy is just “!”; I don't think we need a new library for a more verbose way to express a one-character unary operator, no, nor does it meet the standard of “The problem it solves is not straightforward” proposed upthread.
- drinchev 6y ago
  Oh, the irony ... https://www.npmjs.com/package/is-falsy https://www.npmjs.com/package/is-falsy
  - dragonwriter 6y ago
    I'm not surprised it exists (and literally is just a more verbose, indirect way to invoke “!” that nevertheless is a 17 sloc module with a bunch of ancillary files that has one direct and, by way of that one, 17 second-order and, while I didn't check further, probably an even more ridiculous number of more distant, transitive dependendencies.) I'm just saying it's neither necessary nor consistent with the standard for when a library is a good idea proposed upthread, so suggesting it as part of an attempt at reductio as absurdam on that standard is misplaced.
  - magicalist 6y ago
    > 0 Dependents if a tree falls in the woods...?
    - kemitchell 6y ago
      > Weekly Downloads > > 0 as of 2020-04-26T00:39+00:00
staticassertion 6y ago
All of those can be pretty much be handled natively, and obviously. They're all primitive isFalse would be != isObject would use typeOf isFucntion would use typeOf Where a library becomes helpful is when you have: * A real problem (none of those are real problems, and the npm packages for them are essentially unused jokes) * A solution that is not intuitive, or has a sharp edge, or requires non-obvious knowledge, or does not have a preexisting std approach Checking for a promise, given the constraints of having multiple types of promises out in the world, falls into both of those. Checking if something is falsey, when Javascript provides !, does not fall into either.

enitihas 6y ago

I think all of the above might already be libraries on npm. From what I remember, npm has isInteger, isPositive, is-odd, is-even.

recursive 6y ago
All of the packages you mentioned are maintained by the same guy.
- sergiotapia 6y ago
  Have you seen his twitter? It's incredibly cringey. I don't understand how someone could be so arrogant to claim millions of companies use his software, when his software is isFalse. Not to mention his hundreds of packages that literally just output an emoji.
  - artificial 6y ago
    Reminds me of Dr. Evil’s monologue about his Father making ridiculous claims about inventing the question mark.

dragonwriter 6y ago

isFalsy is just “!”; I don't think we need a new library for a more verbose way to express a one-character unary operator, no, nor does it meet the standard of “The problem it solves is not straightforward” proposed upthread.

drinchev 6y ago
Oh, the irony ... https://www.npmjs.com/package/is-falsy https://www.npmjs.com/package/is-falsy
- dragonwriter 6y ago
  I'm not surprised it exists (and literally is just a more verbose, indirect way to invoke “!” that nevertheless is a 17 sloc module with a bunch of ancillary files that has one direct and, by way of that one, 17 second-order and, while I didn't check further, probably an even more ridiculous number of more distant, transitive dependendencies.) I'm just saying it's neither necessary nor consistent with the standard for when a library is a good idea proposed upthread, so suggesting it as part of an attempt at reductio as absurdam on that standard is misplaced.
- magicalist 6y ago
  > 0 Dependents if a tree falls in the woods...?
  - kemitchell 6y ago
    > Weekly Downloads > > 0 as of 2020-04-26T00:39+00:00

staticassertion 6y ago

All of those can be pretty much be handled natively, and obviously. They're all primitive isFalse would be != isObject would use typeOf isFucntion would use typeOf Where a library becomes helpful is when you have: * A real problem (none of those are real problems, and the npm packages for them are essentially unused jokes) * A solution that is not intuitive, or has a sharp edge, or requires non-obvious knowledge, or does not have a preexisting std approach Checking for a promise, given the constraints of having multiple types of promises out in the world, falls into both of those. Checking if something is falsey, when Javascript provides !, does not fall into either.