8 ms·
I actually enjoy witty and clever commit messages. Just the other day one of my coworkers really enjoyed a commit message where I wrote "upgrayedd" instead of
by mattmichielsen 16y ago
I actually enjoy witty and clever commit messages. Just the other day one of my coworkers really enjoyed a commit message where I wrote "upgrayedd" instead of "upgrade".
- benatkin 16y agoMy guess is that the idea to put that in the commit just came to you. So you didn't necessarily go against his advice: > Don’t try to be clever, witty or funny. I've worked with someone who did sit around thinking what to put in a commit, and believe me, he didn't commit as often as he should have.
- mattmichielsen 16y agoNo, it was pretty spontaneous, as the particular individual who typically works with me on that project and I were having a conversation about Idiocracy just hours prior to that.
- steveklabnik 16y agoUntil you try to search through your history for everywhere you upgraded something... I write my fair share of terrible commit messages, too. It always bites me in the ass eventually.
- TheBurningOr 16y agoI feel like a better approach for that sort of solution would be to use a hash-tag based (#) tagging system. English has so many tenses and people mis-spell things anyways that basing your search purely off of the text of the commit message is always going to be tricky. Anyways, the point of the commit message is that it be human readable, not machine readable. Personally, I like clever commit messages. They remind me that the project was written by humans for humans.
- steveklabnik 16y agoIt's impossible to know what you'll need in the future, and you can't effectively go back and look for tags, though. My approach is to add silly things in as fluff, not as the message itself. The frobnicator now frobnicates. becomes The frobnicator now frobnicates, omgh4x!!!11 or whatever. Make sure you've got enough _real_ information there, and some light extra whatever is fine. Then again, sometimes, you really need good commit messages: http://github.com/shoes/shoes/commit/95fed5e6310cb0174ba80b8d4a5225a16e27c14b http://github.com/shoes/shoes/commit/95fed5e6310cb0174ba80b8...