10 ms·
Over the past year, I've become a bit wiser with some professional experience under my belt and thought of implementing the same idea with different technologie
by salmaanp 9y ago
Over the past year, I've become a bit wiser with some professional experience under my belt and thought of implementing the same idea with different technologies and using best practices, example: the previous version hosted on AWS had security policies set to everything open from everywhere and no SSL certificates. Yes, I've wised up now.
Would love any feedback, especially if you could do a quick code review on my Go and React code!
React: https://github.com/SalmaanP/FastNews-Frontend-React https://github.com/SalmaanP/FastNews-Frontend-React
Go: https://github.com/SalmaanP/FastNews-Backend-Go https://github.com/SalmaanP/FastNews-Backend-Go
For Comparison the previous layout: http://52.34.237.199/ http://52.34.237.199/
- poyu 9y agoHey man, frontend looks fine, but I think some of your APIs are 404 now. There's also missing 'Access-Control-Allow-Origin' header error on some of the endpoints. Keep it up!
- sallurocks 9y agoOh thanks, I need a better way to deploy the go web server, looking at monit and supervisord now. Whicb api is that and how do you even check that? I did have cors enabled while developing since it was running off two different ports, could that be it?
- jo_choih 9y agoIt feels more like a news site than the first iteration. Is there a reason why you're set on having this being a JavaScript app? AMP seems to be pretty popular for news ATM, and that's kind of the opposite approach. Curious what your thinking is. The bullet points summarization stuff is great. That's what I always look for on Reddit posts.
- salmaanp 9y agoIts just a means of learning for me. Wanted to learn React and so got on implementing it on a project. I have looked at AMP and it's not hard to implement but that's not what I am going for.
- dharness 9y agoThe new UI is much nicer! I'd prefer pictures, though.