6 ms·
It's open source: https://acss.io https://acss.io
by nates 9y ago
It's open source: https://acss.io https://acss.io
- gvx 9y agoI hope they'll accept my pull request: https://github.com/acss-io/atomizer/pull/302 https://github.com/acss-io/atomizer/pull/302
- winstonewert 9y agoYou could at least ensure the CI tests still pass. :P
- juanpotato 9y agoNo need for tests to pass if they don't exist ¯\_(ツ)_/¯
- awinder 9y agoNeed to provide tests to make sure that the original problem doesn’t crop up again ;-)
- coke12 9y agoWhy would you do this?
- treve 9y agoYou're an awful person.
- _Marak_ 9y agoFor everyone reading these comments, I want to say that this kind of pull request is hurtful and unwarranted. You've essentially sent an alert to someone ( or a group of people ) saying that you believe their work has no value. This kind of behavior could have real-world consequences. You could be pushing someone to not work on open-source again, or make them feel worse about working on a project they might be required to contribute to as part of their job. How would you feel if someone started vandalizing your own github projects gvx? Would it make you feel good? Would you consider it funny?
- mrkrabo 9y agoThis is ridiculous. If someone tells you your project is bollocks and you decide to quit the open source world altogether, maybe that world was better off without you.
- pier25 9y agoSo because some people might take criticism personally we shouldn't be allowed to express criticism?
- romanovcode 9y agoThis kind of criticism has 0 value. It basically says "you suck!". OP needs to grow up.
- pier25 9y agoI asked a question because I want to start a debate, which is quite different.
- matt_kantor 9y agoYou're allowed to be a jerk, but when doing so you shouldn't be surprised if people call you a jerk (or use a nicer phrase like "this kind of pull request is hurtful and unwarranted"). Constructive criticism is good, but the linked PR is not that. It's akin to a content-less drive-by HN comment like "you suck". You're free to post it (until you get banned), but it's not adding anything and you should expect downvotes.
- pier25 9y agoI agree with you and I'm not saying "delete your fucking project" is constructive criticism. But, if an internet stranger says "delete your fucking project" and you take that personally there's no one to blame for your suffering than yourself. Also, _Marak_'s paternalistic comment would make sense with a group of 10 year olds, but we are all adults here.