4 ms·
For a <5Kb library, I recommend removing the underscore dependency. You should make this as lightweight as possible if you want a lot of adoption.
by dc2 9y ago
For a <5Kb library, I recommend removing the underscore dependency. You should make this as lightweight as possible if you want a lot of adoption.
- kauegimenes 9y agoThanks for the tip, you are welcome to submit a PR if you want to =)
- d2xdy2 9y agoNot OP, but I just submitted a PR removing underscore as a dep. :)
- kauegimenes 9y agoThats awesome! thanks! PR: https://github.com/kauegimenes/jsonexport/pull/27 https://github.com/kauegimenes/jsonexport/pull/27
- kauegimenes 9y agoThis is now avaliable in v2.0.7 =) Dependencies None
- stdbrouw 9y agoConverting to CSV is mainly a server-side problem, not something you'd want to do in the browser, so this doesn't really feel like an issue to me.
- JoshGlazebrook 9y agoYeah this looks like it's only using helper functions like _.isFunction(), _.isNumber(), and _.extend().