6 ms·
That's a LOT of code in the controllers. If I had to guess, it sounds like they're putting business logic in their controllers, which is a fairly well-establish
by Humjob 10y ago
That's a LOT of code in the controllers. If I had to guess, it sounds like they're putting business logic in their controllers, which is a fairly well-established anti-pattern.
How's Shopify's platform performing these days?
- pmontra 10y agoThey have 452 classes in controllers and 41374 LOC. It's an average of 91.5 lines of Ruby per controller, not so many for the usual 7 scaffolded methods and some extras like strong params. About performances, I always thought that writing logic in controllers, models or lib was a matter of readability and ease of maintenance. Does it make a difference to the CPU if 50 lines of code run in a controller or in a model or in a file in lib or in a gem? Maybe do 452 controllers slow down the router?
- kondro 10y agoExcellently.