8 ms·

Co-author here. Happy to answer any questions folks have about Phan.

by asm 11y ago

cweagans 11y ago
This is awesome. Any plans to add autocomplete functionality similar to HHVM's typechecker?
- asm 11y ago
  We'd like to get there eventually. Phan populates a sqlite database when analyzing code (if run with the -s flag). This allows fast runs on single file changes or patches. We're hoping to use this for things like auto-complete and finding callers for a class/method/whatever eventually. For now, we have a primordial Syntastic vim plugin (https://github.com/etsy/phan/blob/master/plugins/vim/bundle/syntastic/syntax_checkers/php/phan.vim https://github.com/etsy/phan/blob/master/plugins/vim/bundle/...) for getting errors into the quickfix view.
  - cweagans 11y ago
    That's awesome. If a PR was opened that added autocomplete and/or finding callers and/or refactoring (and assuming that the code is good), would you guys be open to merging it? Or would it be delayed so that the core functionality can be focused on?
    - asm 11y ago
      Definitely. If you want to start working on that, feel free to open up an issue (https://github.com/etsy/phan/issues/new https://github.com/etsy/phan/issues/new) to start a conversation about it. We currently store method/function callers in the sqlite database (see https://github.com/etsy/phan/blob/master/src/Phan/Analyze/BreadthFirstVisitor.php#L922-L929 https://github.com/etsy/phan/blob/master/src/Phan/Analyze/Br...), but aren't yet exposing an interface for getting callers. We'll want to store callers for constants, classes, properties and global variables as well.
- allan_s 11y ago
  Meanwhile, have you checked padawan ? https://github.com/mkusher/padawan.php https://github.com/mkusher/padawan.php it's a server made to be used by editors for autocompletion of PHP code (like jedi for python) it works pretty well with vim AFAIK
  - cweagans 11y ago
    Yep. https://github.com/mkusher/padawan.php/issues/1 https://github.com/mkusher/padawan.php/issues/1 Project started after mine. https://github.com/cweagans/theforce https://github.com/cweagans/theforce Just ran out of time, so mkusher did his own thing. I disagree with his direction and I think it's overly complex from a user's standpoint, but he disagrees and isn't willing to change it, so I lost interest in that project too. Using the actual AST from the PHP interpreter is going to be a) much faster and b) much more accurate.
gravypod 11y ago
How Phan treat SIMD in PHP7? Does it pick up what is going on with functions as variables?
- asm 11y ago
  Phan does not attempt to make sense of things like `$class_name->$function_name()` or `$$v`. I'd be happy to see a pull request that could handle simple strings, but otherwise I imagine the best we can do is emit a warning. I'm not sure what SIMD refers to. Can you clarify that?
  - merlincorey 11y ago
    > I'm not sure what SIMD refers to. Can you clarify that? With a name like "asm" that comes as a surprise... Single Instruction Multiple Data[0] refers to low level processor instructions that are able to work across a range of data, e.g. video cards working on changing the values in a framebuffer with one instruction mapping across an entire buffer in parallel. [0] https://en.wikipedia.org/wiki/SIMD https://en.wikipedia.org/wiki/SIMD
    - giaour 11y ago
      That doesn't clarify what the OP meant. PHP does not allow you to issue processor instructions directly.
    - psaintla 11y ago
      I'm going to take a crazy leap here based on the commits. asm might not stand for what you think.
  - StefanKarpinski 11y ago
    What about `$$$v`? Does it handle `$$$v`?
  - gravypod 11y ago
    I wrote this when I had just woke up as I was excited, so I had to get a question in. I think what I meant was passing functions into other functions. I do this for things like: $user_requirements = [filter1, filter2]; foreach ($user_requirements as $test) { if (!$test($some_data)) { return false; } return true; } Is there any way to tell the analyzer to make sure that afunction of n arguments is passed in?
durich 11y ago
Awesome project, Do you know where I can download a php_ast.dll for the latest php 7 for windows?
- asm 11y ago
  I'm not sure. PHP7 is pretty new so package maintainers may not have had a chance to put binary releases together. You may need to compile it yourself from https://github.com/nikic/php-ast https://github.com/nikic/php-ast.
cdnsteve 11y ago
How is performance of Phan? Nested looping checks in phase 2 scans sound intensive and bottleneck-ish.
- asm 11y ago
  Analysis takes a lot of CPU and we're not doing any parallel processing. Phan itself is about 30k lines of code and takes about 1.5s for a clean run. That being said, you should take a look at the '-s' flag for saving state to a sqlite database. After the initial run the stored state can be used to only scan changed files. For a patch with a few files changed it should be about 0.5s to run the analysis.
mcfunley 11y ago
Am I right in assuming that the name is a tribute to John Allspaw's rec.music.phish posts from the 90s? https://groups.google.com/forum/#!search/allspaw$20phriend%7Csort:relevance%7Cspell:false/rec.music.phish/8xedeCvJSAM/U9rSD7a0K54J https://groups.google.com/forum/#!search/allspaw$20phriend%7...

Co-author here. Happy to answer any questions folks have about Phan.

by asm 11y ago

Co-author here. Happy to answer any questions folks have about Phan.

cweagans 11y ago

This is awesome. Any plans to add autocomplete functionality similar to HHVM's typechecker?

asm 11y ago
We'd like to get there eventually. Phan populates a sqlite database when analyzing code (if run with the -s flag). This allows fast runs on single file changes or patches. We're hoping to use this for things like auto-complete and finding callers for a class/method/whatever eventually. For now, we have a primordial Syntastic vim plugin (https://github.com/etsy/phan/blob/master/plugins/vim/bundle/syntastic/syntax_checkers/php/phan.vim https://github.com/etsy/phan/blob/master/plugins/vim/bundle/...) for getting errors into the quickfix view.
- cweagans 11y ago
  That's awesome. If a PR was opened that added autocomplete and/or finding callers and/or refactoring (and assuming that the code is good), would you guys be open to merging it? Or would it be delayed so that the core functionality can be focused on?
  - asm 11y ago
    Definitely. If you want to start working on that, feel free to open up an issue (https://github.com/etsy/phan/issues/new https://github.com/etsy/phan/issues/new) to start a conversation about it. We currently store method/function callers in the sqlite database (see https://github.com/etsy/phan/blob/master/src/Phan/Analyze/BreadthFirstVisitor.php#L922-L929 https://github.com/etsy/phan/blob/master/src/Phan/Analyze/Br...), but aren't yet exposing an interface for getting callers. We'll want to store callers for constants, classes, properties and global variables as well.
allan_s 11y ago
Meanwhile, have you checked padawan ? https://github.com/mkusher/padawan.php https://github.com/mkusher/padawan.php it's a server made to be used by editors for autocompletion of PHP code (like jedi for python) it works pretty well with vim AFAIK
- cweagans 11y ago
  Yep. https://github.com/mkusher/padawan.php/issues/1 https://github.com/mkusher/padawan.php/issues/1 Project started after mine. https://github.com/cweagans/theforce https://github.com/cweagans/theforce Just ran out of time, so mkusher did his own thing. I disagree with his direction and I think it's overly complex from a user's standpoint, but he disagrees and isn't willing to change it, so I lost interest in that project too. Using the actual AST from the PHP interpreter is going to be a) much faster and b) much more accurate.

gravypod 11y ago

How Phan treat SIMD in PHP7? Does it pick up what is going on with functions as variables?

asm 11y ago
Phan does not attempt to make sense of things like `$class_name->$function_name()` or `$$v`. I'd be happy to see a pull request that could handle simple strings, but otherwise I imagine the best we can do is emit a warning. I'm not sure what SIMD refers to. Can you clarify that?
- merlincorey 11y ago
  > I'm not sure what SIMD refers to. Can you clarify that? With a name like "asm" that comes as a surprise... Single Instruction Multiple Data[0] refers to low level processor instructions that are able to work across a range of data, e.g. video cards working on changing the values in a framebuffer with one instruction mapping across an entire buffer in parallel. [0] https://en.wikipedia.org/wiki/SIMD https://en.wikipedia.org/wiki/SIMD
  - giaour 11y ago
    That doesn't clarify what the OP meant. PHP does not allow you to issue processor instructions directly.
  - psaintla 11y ago
    I'm going to take a crazy leap here based on the commits. asm might not stand for what you think.
- StefanKarpinski 11y ago
  What about `$$$v`? Does it handle `$$$v`?
- gravypod 11y ago
  I wrote this when I had just woke up as I was excited, so I had to get a question in. I think what I meant was passing functions into other functions. I do this for things like: $user_requirements = [filter1, filter2]; foreach ($user_requirements as $test) { if (!$test($some_data)) { return false; } return true; } Is there any way to tell the analyzer to make sure that afunction of n arguments is passed in?

durich 11y ago

Awesome project, Do you know where I can download a php_ast.dll for the latest php 7 for windows?

asm 11y ago
I'm not sure. PHP7 is pretty new so package maintainers may not have had a chance to put binary releases together. You may need to compile it yourself from https://github.com/nikic/php-ast https://github.com/nikic/php-ast.

cdnsteve 11y ago

How is performance of Phan? Nested looping checks in phase 2 scans sound intensive and bottleneck-ish.

asm 11y ago
Analysis takes a lot of CPU and we're not doing any parallel processing. Phan itself is about 30k lines of code and takes about 1.5s for a clean run. That being said, you should take a look at the '-s' flag for saving state to a sqlite database. After the initial run the stored state can be used to only scan changed files. For a patch with a few files changed it should be about 0.5s to run the analysis.

mcfunley 11y ago

Am I right in assuming that the name is a tribute to John Allspaw's rec.music.phish posts from the 90s? https://groups.google.com/forum/#!search/allspaw$20phriend%7Csort:relevance%7Cspell:false/rec.music.phish/8xedeCvJSAM/U9rSD7a0K54J https://groups.google.com/forum/#!search/allspaw$20phriend%7...