4 ms·
Hi sandofsky, that was our previous implementation (dismissal starts only when user's touch enters the real keyboard area) - it doesn't feel 'right'. The libra
by ayrkm 11y ago
Hi sandofsky, that was our previous implementation (dismissal starts only when user's touch enters the real keyboard area) - it doesn't feel 'right'.
The library is not really using KVO to observe private APIs, bounds/center of UIView is public property.
- sandofsky 11y agoYou're observing the superview in a hierarchy you don't own. In your code, you have an iOS version check, presumably since the property you're looking for changed between iOS versions.
- ayrkm 11y agoyes, that I agree, it may break between iOS versions. i'm all ear to other approach if any
- sandofsky 11y agoYou file a ticket with Apple and stick with documented APIs.
- ayrkm 11y agowill do and hope Apple may do something about that. until then, will stick to current solution and test ahead of any new iOS release.
- sandofsky 11y agoYou've decided on the path of higher maintenance, and you've increased the risk of Apple rejection. Maybe this decision won't bite you, but this mentality will.
- ayrkm 11y agoi keep my options open until I find a better solution. i'm assuming engineers that build FB messenger, WhatsApp, Twitter etc. could be using similar approach, but I am more than happy to be proven wrong.